feat: Add txMeta
to GetSimulationConfig
#6833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the only information the
GetSimulationConfig
callback gets is the simulation server URL.In MetaMask Shield we identified an edge case, where it would be useful for the backend to be provided with the transaction origin.
We here propose to add
txMeta
as an optional context parameter to theGetSimulationConfig
callback, so that the callback can attach theorigin
(contained intxMeta
) to the backend URL as a URL parameter.References
Checklist
Note
Adds optional txMeta to GetSimulationConfig and wires TransactionController to pass txMeta when requesting simulation config, with tests and changelog updates.
GetSimulationConfig
signature to(url, opts?: { txMeta? })
insrc/types.ts
.getSimulationConfig
inTransactionController
to inject currenttxMeta
when simulating (#updateSimulationData
).getSimulationConfig
to be called (with URL and{ txMeta }
) and adjust mocks accordingly.CHANGELOG.md
under Unreleased.Written by Cursor Bugbot for commit e1debf3. This will update automatically on new commits. Configure here.