fix: add minimumVersion requirement when checking SSE feature flag #6891
+293
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This replaces the
sseEnabled
flag with a record that also includes the minimum required client version. This ensures that older clients are not affected when we enable SSE in the futureNew flag format
References
Checklist
Note
Replace
sseEnabled
withsse { enabled, minimumVersion }
and gate SSE by client version; makeclientVersion
required inBridgeController
and update validators/tests accordingly.clientVersion
inBridgeController
constructor; propagate to API calls and tests.sseEnabled
withsse { enabled, minimumVersion }
; addhasMinimumRequiredVersion
and use it to decide streaming; update flag access in controller.VersionStringSchema
; changePlatformConfigSchema
tosse
object withminimumVersion
and removesseEnabled
.BridgeController
initialization by passingclientVersion
.Written by Cursor Bugbot for commit 6e55d3e. This will update automatically on new commits. Configure here.