add refresh events to account tracker controller #6903
Merged
+160
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
commented
Oct 21, 2025
| ) as ChecksumAddress, | ||
| queryAllAccounts, | ||
| selectedAccount, | ||
| allAccounts, |
There was a problem hiding this comment.
I didn't want to make any further changes here in case we have to end up cherrypicking this as a patch, but we should not defer this logic to the fetchers.
The fetchers should receive just an array of chainIds and an array of addresses (which could be one address). The only thing both of them do internally is use allAccounts (only the address) or selectedAccount depending on whether queryAllAccounts is true or false.
salimtb
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds single address balance refresh based on transaction events to make up for removing them on extension client side during migration.
Previews:
MetaMask/metamask-extension#36808
MetaMask/metamask-mobile#21465
References
Checklist
Note
AccountTrackerController now subscribes to transaction events to trigger targeted (single-address) balance refreshes, with internal refresh refactor and accompanying tests; changelog updated (breaking note).
TransactionController:unapprovedTransactionAddedandTransactionController:transactionConfirmedto refresh balances.#refreshAddressand refactorrefreshinto#refreshAccountsfor single-address updates; passqueryAllAccounts, checksumselectedAccount, andallAccountsto fetchers.AllowedEventsto include transaction events; wire subscriptions in constructor.packages/assets-controllers/src/AccountTrackerController.test.ts):messengerand allow new events.[Unreleased].Written by Cursor Bugbot for commit 8ccaf66. This will update automatically on new commits. Configure here.