fix(base-controller): add TypeScript declaration file for legacy module resolution #6915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le resolution Added next.d.ts file to support importing from '@metamask/base-controller/next' with legacy TypeScript module resolution. Previously, this import pattern only worked with Node16/NodeNext resolution which uses the exports field in package.json. This ensures compatibility with projects using older TypeScript module resolution settings while maintaining support for modern resolution modes.
cryptodev-2s
force-pushed
the
fix/base-controller-legacy-ts-resolution
branch
from
f260a25 to
bf9c17c
Compare
Mrtenz
previously approved these changes
Oct 22, 2025
cryptodev-2s
commented
Oct 22, 2025
Mrtenz
approved these changes
Oct 22, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| // Re-export all types and values from the CommonJS build | ||
| // eslint-disable-next-line import-x/no-useless-path-segments, import-x/extensions | ||
| export * from './dist/next/index.cjs'; |
There was a problem hiding this comment.
Bug: TypeScript Re-export Issue
The next.d.ts file re-exports from ./dist/next/index.cjs, a JavaScript file, instead of its corresponding TypeScript declaration file (./dist/next/index.d.cts). This prevents proper type resolution for consumers using legacy module resolution.
Gudahtt
added a commit
that referenced
this pull request
Oct 24, 2025
…r/multichain-transactions-controller * origin/main: (35 commits) feat: `JsonRpcEngineV2` (#6176) Release 641.0.0 (#6940) feat: Add transaction emulation actions (#6935) Release/640.0.0 (#6934) fix(core-backend): control randomness to fix flaky test (#6936) chore: Add `@metamask-previews/*` to NPM age gate exceptions (#6937) Release/639.0.0 (#6931) feat: make getCryptoApproveTransactionParams synchronous (#6930) feat: add new actions to `KeyringController` (#6928) feat: add `getAccounts` to `AccountsController` (#6927) chore: remove `Monad Mainnet` single call balance contract and add into account v4 (#6929) Release/638.0.0 (#6923) fix: Downgrade `multiformats` to `^9.9.0` to avoid ESM-only dependency (#6920) Release/637.0.0 (#6919) feat(account-tree-controller): add callbacks for hidden and pinned data (#6910) Release 636.0.0 (#6918) fix(core-backend): reconnection logic (#6861) fix: Tx state listener and signature coverage (#6906) Release/635.0.0 (#6917) fix(base-controller): add TypeScript declaration file for legacy module resolution (#6915) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Added next.d.ts file to support importing from '@metamask/base-controller/next' with legacy TypeScript module resolution. Previously, this import pattern only worked with Node16/NodeNext resolution which uses the exports field in package.json.
This ensures compatibility with projects using older TypeScript module resolution settings while maintaining support for modern resolution modes.
References
Checklist
Note
Add
next.d.tsto enable@metamask/base-controller/nextimports under legacy TypeScript module resolution; include it in package files and update changelog.packages/base-controller/next.d.tsre-exporting./dist/next/index.cjsto support legacy module resolution for@metamask/base-controller/next.next.d.tsinpackages/base-controller/package.jsonfilesarray./nextsubpath.Written by Cursor Bugbot for commit d232e39. This will update automatically on new commits. Configure here.