feat: New base-controller API

[Gudahtt]

Explanation

The @metamask/base-controller package has been updated to use the new API that had previously been exposed under the next export. Major changes include:

• Remove Messenger and RestrictedMessenger
  • Replaced by the @metamask/messenger library
• Update BaseController to require @metamask/messenger instance
• Rename anonymous metadata property to includeInDebugLogs
• Make includeInStateLogs and usedInUi metadata properties required
• Remove getPersistentState and getAnonymizedState
• Remove isBaseController
• Rename ListenerV2 to StateChangeListener
• Rename messagingSystem protected instance variable to messenger
• Remove next export

References

Relates to #5626

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

---

Note

Migrate all packages to the new @metamask/base-controller API using @metamask/messenger, remove the /next export and legacy messenger, and update metadata types and configs accordingly.

• base-controller (BREAKING):
  • Replace internal Messenger/RestrictedMessenger with @metamask/messenger; BaseController now requires a Messenger instance.
  • Remove /next export and legacy files (src/next/*, next.js, next.d.ts).
  • Rename metadata anonymous -> includeInDebugSnapshot; require includeInStateLogs and usedInUi.
  • Rename ListenerV2 -> StateChangeListener; rename messagingSystem -> messenger.
  • Remove getPersistentState, getAnonymizedState, and isBaseController.
  • Update types and implementation to new messenger integration and events.
  • Update CHANGELOG.md with breaking changes.
• Repo-wide refactor:
  • Change imports from @metamask/base-controller/next to @metamask/base-controller across controllers/tests (accounts, assets, network, permissions, transactions, etc.).
  • Update tests to use @metamask/messenger and new metadata keys.
• Config/build:
  • Remove Jest moduleNameMapper for /next; adjust TypeScript paths and add skipLibCheck in tsconfig.packages.build.json.
  • Update eslint-warning-thresholds.json accordingly.

^{Written by Cursor Bugbot for commit 61b5206. This will update automatically on new commits. Configure here.}

[mikesposito]

LGTM!

[cursor]

Bug: Metadata Constraint Mismatch Causes Type Issues

The StatePropertyMetadataConstraint type is out of sync with StatePropertyMetadata. It still uses anonymous instead of includeInDebugSnapshot, and its includeInStateLogs and usedInUi properties are optional when they should be required. This mismatch causes type compatibility issues.

 

[cursor]

Bug: Inconsistent Messenger Usage in BaseController Methods

The destroy method uses this.messenger.clearEventSubscriptions() while the update and applyPatches methods use this.#messenger.publish(). This is inconsistent. The destroy method should use this.#messenger.clearEventSubscriptions() to be consistent with the other methods that interact with the messenger for BaseController-specific actions/events. Using this.messenger instead of this.#messenger bypasses the type safety that restricts the messenger to only BaseController's own actions and events.

 

[Gudahtt]

I have added no-changelog because the removal of the /next imports in most packages doesn't constitute a change since the previous published version.

[mikesposito]

LGTM!

[Gudahtt]

Rebased to resolve conflicts

[mikesposito]

LFG!