Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Oct 27, 2025

Explanation

A test fixture used by the package @metamask/profile-sync-controller has been migrated to use the new @metamask/messenger package, in praration for the Messenger being removed from @metamask/base-controller.

References

Relates to #5626

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Switches the contact-syncing test fixture to use @metamask/messenger with namespaced Messenger and updated types.

  • Tests (contact syncing):
    • Replace @metamask/base-controller Messenger with @metamask/messenger Messenger in __fixtures__/test-utils.ts.
    • Add MockAnyNamespace typing and initialize Messenger with MOCK_ANY_NAMESPACE.
    • Update generic types (ActionConstraint, EventConstraint) and imports to align with @metamask/messenger API.

Written by Cursor Bugbot for commit caf2a47. This will update automatically on new commits. Configure here.

A test fixture used by the package `@metamask/profile-sync-controller` has been
migrated to use the new `@metamask/messenger` package, in praration for the
`Messenger` being removed from `@metamask/base-controller`.

Relates to #5626
@Gudahtt Gudahtt changed the title chore: Migrate test fixture to messeger chore: Migrate test fixture to messenger Oct 27, 2025
@Gudahtt Gudahtt marked this pull request as ready for review October 27, 2025 15:52
@Gudahtt Gudahtt requested a review from a team as a code owner October 27, 2025 15:52
@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 27, 2025

I've labelled this as no-changelog because it only impacts a test fixture. No functional changes for the package.

@Gudahtt Gudahtt enabled auto-merge October 27, 2025 15:55
@Gudahtt Gudahtt added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 93ab3b4 Oct 27, 2025
256 of 257 checks passed
@Gudahtt Gudahtt deleted the migrate-profile-sync-controller-fixture branch October 27, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants