Skip to content

Conversation

@juanmigdr
Copy link
Member

@juanmigdr juanmigdr commented Oct 28, 2025

Explanation

The feature to hide tokens is available for EVM assets but not for non-EVM assets. This task involves implementing a similar token hiding feature for non-EVM assets. This is crucial for improving user experience by allowing users to hide unwanted tokens, especially in light of spam and malicious token issues. The implementation should be prioritized to align with upcoming Solana campaigns.

NOTE:

  • Changes are needed on Mobile and extension to support this

References

https://consensyssoftware.atlassian.net/browse/ASSETS-1425

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Introduce allIgnoredAssets and ignoreAssets in MultichainAssetsController and filter ignored non-EVM assets in selectors and balance calculations.

  • MultichainAssetsController:
    • Add allIgnoredAssets to state and default metadata; clean up on account removal.
    • New action ignoreAssets(accountId, assets); register handler and expose via messenger.
    • Filter ignored assets in accountAssetListUpdated handling.
    • Add helper #isAssetIgnored and related tests.
  • Balances (src/balances.ts):
    • Accept MultichainAssetsControllerState in calculators; exclude allIgnoredAssets from non‑EVM balance totals and change calculations.
  • Selectors (selectors/token-selectors.ts):
    • Extend AssetListState with allIgnoredAssets; omit ignored multichain assets in selectAllMultichainAssets.
  • Tests:
    • Update/expand tests across assets controller, balances, rates controller, and selectors to cover ignore behavior and new function signatures.
  • Changelog:
    • Note addition of ignoreAssets for non‑EVM chains.

Written by Cursor Bugbot for commit 0846036. This will update automatically on new commits. Configure here.

@juanmigdr juanmigdr marked this pull request as ready for review October 29, 2025 15:55
@juanmigdr juanmigdr requested a review from a team as a code owner October 29, 2025 15:55
cursor[bot]

This comment was marked as outdated.

@juanmigdr juanmigdr requested a review from a team as a code owner October 29, 2025 16:26
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@juanmigdr juanmigdr enabled auto-merge (squash) October 29, 2025 16:39
@juanmigdr juanmigdr merged commit 740dfec into main Oct 29, 2025
255 checks passed
@juanmigdr juanmigdr deleted the feat/support-ignore-non-evm branch October 29, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants