Skip to content

Conversation

@bergarces
Copy link
Contributor

@bergarces bergarces commented Oct 28, 2025

Explanation

Currently, non-evm native assets were identified by a static list.

With this change, they will be identified when using slip44 as part of the asset namespace, instead of token.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Infer isNative for non‑EVM assets from slip44 namespace and export AssetsByAccountGroup type.

  • Selectors
    • Update selectAllMultichainAssets in selectors/token-selectors.ts to set isNative when caipAsset.assetNamespace === 'slip44' (remove static MULTICHAIN_NATIVE_ASSET_IDS).
  • Exports
    • Export AssetsByAccountGroup from selectors/token-selectors via src/index.ts.
  • Docs
    • Update CHANGELOG.md for the new export and isNative detection change.

Written by Cursor Bugbot for commit f2bf02b. This will update automatically on new commits. Configure here.

@bergarces bergarces force-pushed the better-native-asset-check branch from 1da0c44 to 736cffe Compare October 28, 2025 16:32
@bergarces bergarces changed the title better detection of native multichain assets feat: better detection of native multichain assets Nov 3, 2025
@bergarces bergarces marked this pull request as ready for review November 3, 2025 15:19
@bergarces bergarces requested review from a team as code owners November 3, 2025 15:19
@bergarces bergarces merged commit f6d4f2e into main Nov 3, 2025
262 checks passed
@bergarces bergarces deleted the better-native-asset-check branch November 3, 2025 15:29
juanmigdr pushed a commit that referenced this pull request Nov 3, 2025
<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

Currently, non-evm native assets were identified by a static list.

With this change, they will be identified when using `slip44` as part of
the asset namespace, instead of `token`.

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Infer `isNative` for non‑EVM assets from `slip44` namespace and export
`AssetsByAccountGroup` type.
>
> - **Selectors**
> - Update `selectAllMultichainAssets` in `selectors/token-selectors.ts`
to set `isNative` when `caipAsset.assetNamespace === 'slip44'` (remove
static `MULTICHAIN_NATIVE_ASSET_IDS`).
> - **Exports**
> - Export `AssetsByAccountGroup` from `selectors/token-selectors` via
`src/index.ts`.
> - **Docs**
> - Update `CHANGELOG.md` for the new export and `isNative` detection
change.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
f2bf02b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants