Add KeyringController wrapper and a CoreController #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
pushed a commit
that referenced
this pull request
Jul 17, 2023
Adds automated API docs generation via `typedoc` and automated publishing to GitHub pages. Closely follows the implementation in MetaMask/eth-sig-util#207 and MetaMask/eth-sig-util#213, but uses https://github.com/peaceiris/actions-gh-pages instead of our own GitHub Pages action, which we plan to sunset.
kanthesha
pushed a commit
that referenced
this pull request
Sep 19, 2023
* use yarn; update dev dependencies * standardize repo Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Sep 22, 2023
The version has been changed to v0.0.1 so that the first release can be v1. I set this to v1 forgetting that our release automation would also attempt to set this.
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
Bugfix: use spread notation to clone request object
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* use yarn; update dev dependencies * standardize repo Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* use yarn; update dev dependencies * standardize repo Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
* use yarn; update dev dependencies * standardize repo Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Validate singer addresses for signTypedData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.