Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Oct 31, 2025

Explanation

The engine option of the JsonRpcServer constructor param was improperly genericized and didn't actually work in practice. This is now fixed.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Properly types JsonRpcServer constructor engine option using ReturnType<typeof JsonRpcEngineV2.create<...>> and updates the changelog entry.

  • Types:
    • Update JsonRpcServer Options.engine to ReturnType<typeof JsonRpcEngineV2.create<Middleware>> for correct generics in src/v2/JsonRpcServer.ts.
  • Docs:
    • Add PR reference #7032 to JsonRpcEngineV2 entry in packages/json-rpc-engine/CHANGELOG.md.

Written by Cursor Bugbot for commit 36bbe31. This will update automatically on new commits. Configure here.

@rekmarks rekmarks marked this pull request as ready for review October 31, 2025 18:29
@rekmarks rekmarks requested review from a team as code owners October 31, 2025 18:29
@rekmarks rekmarks enabled auto-merge (squash) October 31, 2025 18:30
@rekmarks rekmarks disabled auto-merge October 31, 2025 18:52
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks enabled auto-merge (squash) October 31, 2025 19:40
@rekmarks rekmarks merged commit eea058a into main Oct 31, 2025
259 checks passed
@rekmarks rekmarks deleted the rekm/jrpce-server-type-fix branch October 31, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants