Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 3, 2025

Explanation

This fixes the build script for all packages by adding @ts-bridge/cli as devDependency, and includes an additional build:all script to build packages including their dependencies. This is a bit slower than building one package, so I didn't set it as default.

References

Closes #4960.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds @ts-bridge/cli as a devDependency and introduces a consistent build:all script across packages, with constraints and formatting updates.

  • Build/Tooling:
    • Add @ts-bridge/cli as a devDependency across workspace packages.
    • Introduce scripts.build:all (ts-bridge ... --clean) in all non-root packages and enforce via yarn.config.cjs constraints.
    • Minor script tidy-ups (e.g., reorder or add since-latest-release, ensure publish:preview presence where required).
  • Formatting:
    • Add Prettier plugin prettier-plugin-packagejson in .prettierrc.js.
  • Dependencies:
    • Update yarn.lock to reflect new dev dependencies.

Written by Cursor Bugbot for commit 9c4a1c3. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz changed the title Mrtenz/add ts bridge to packages fix: Fix build script not working because of missing @ts-bridge/cli dependency Nov 3, 2025
singleQuote: true,
tabWidth: 2,
trailingComma: 'all',
plugins: ['prettier-plugin-packagejson'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly required for this PR, but I noticed Prettier wasn't updating the order of scripts in package.json. Turns out we never added prettier-plugin-packagejson to the config after bumping to Prettier 3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, this is my fault, thanks for adding this.

@Mrtenz Mrtenz marked this pull request as ready for review November 3, 2025 13:15
@Mrtenz Mrtenz requested review from a team as code owners November 3, 2025 13:15
@cryptodev-2s
Copy link
Contributor

@Mrtenz I am wondering when are we supposed to use this new script ?

@Mrtenz
Copy link
Member Author

Mrtenz commented Nov 3, 2025

@Mrtenz I am wondering when are we supposed to use this new script ?

@cryptodev-2s This is mainly for local development. build can be used to just build a single package, and build:all to build a package and only its dependencies. This is a bit quicker than building everything in the repository (especially as we're adding more packages).

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit ed18a2b into main Nov 3, 2025
278 of 279 checks passed
@Mrtenz Mrtenz deleted the mrtenz/add-ts-bridge-to-packages branch November 3, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package-specific build scripts are broken

4 participants