Remove all network-controller lint warnings

[mcmire]

Explanation

Existing lint warnings within the network-controller package were making it difficult to identify new warnings. This commit resolves all of them. There should be no network-controller warnings listed in eslint-warning-thresholds.json.

References

(N/A)

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

---

Note

Eliminates network-controller ESLint warnings by tweaking error handling, promise usage, and tests, and removing the package’s entries from eslint-warning-thresholds.json.

• Lint thresholds:
  • Remove all packages/network-controller/* entries from eslint-warning-thresholds.json.
• Network controller (packages/network-controller/src/NetworkController.ts):
  • Add comment and inline disable to allow rejecting non-Error from JsonRpcEngine in #getLatestBlock.
• Tests (packages/network-controller/tests/NetworkController.test.ts):
  • Use bare catch {} where the error value is unused.
  • Await blockTracker?.destroy() to avoid floating-promise warning.
  • Reject with new Error(...) and coerce eventType via String(eventType) to satisfy template and type rules.

^{Written by Cursor Bugbot for commit d6d3ef7. This will update automatically on new commits. Configure here.}

[mcmire]

Adding no-changelog because none of these changes are user-facing.

[cryptodev-2s]

LGTM!