Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 9, 2025

Explanation

Determine Relay provider fees directly from data with no calculation.

References

Related to #6186

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Read provider fees directly from Relay response (fees.relayer.amountUsd) and update quote normalization, types, and tests accordingly.

  • Relay strategy
    • Fee source: Use fees.relayer.amountUsd for provider fee in normalizeQuote instead of deriving from details.
    • Types: Update RelayQuote to remove details.currencyIn and replace fees.gas with fees.relayer in src/strategy/relay/types.ts.
    • Normalization: Adjust provider fee calculation in src/strategy/relay/relay-quotes.ts.
  • Tests
    • Update relay-quotes.test.ts mocks and expectations to align with new fees.relayer structure and provider fee calculation.
  • Changelog
    • Add entry: Read Relay provider fees directly from response.

Written by Cursor Bugbot for commit b91a4ca. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 force-pushed the fix/relay-provider-fees branch from 7ed52a4 to b91a4ca Compare November 10, 2025 13:10
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 10, 2025 13:12
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners November 10, 2025 13:12
@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) November 10, 2025 13:20
@matthewwalsh0 matthewwalsh0 merged commit bd65e7f into main Nov 10, 2025
273 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/relay-provider-fees branch November 10, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants