Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 10, 2025

Explanation

Fix all auto-fixable ESLint warnings. These changes were generated by running yarn eslint --fix.

There were a number of blank JSDoc entries added by the initial auto-fix command, which had to be reverted because the empty blocks generated errors. The JSDoc auto-fix rules also messed up some of our malformated type doc blocks, which were reverted as well (the current invalid syntax isn't good, but we should at least preserve it until we can fix it properly).

I also had to do a manual pass to remove obsolete comments and extra newlines from the auto-fix rule that removed unused ESLint ignore directives.

Aside from that, everything else ESLint recognized as auto-fixable seems to have been fixed correctly.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Repo-wide ESLint autofixes: mark private fields as readonly, reorder imports, clean/adjust ESLint disables and JSDoc, switch some re-exports to type-only, and update lint warning thresholds; no functional changes.

  • Codebase-wide ESLint autofixes:
    • Mark many private fields as readonly (e.g., in ApprovalController, RatesController, TokenRatesController, NameController, various providers/controllers/tests).
    • Reorder/normalize imports across numerous files and tests.
    • Remove or relocate obsolete eslint-disable comments; trim extra newlines and comments.
    • JSDoc tidying: add missing spacing, brief descriptions, and param docs; remove empty/malformed blocks.
    • Convert some re-exports to type-only (e.g., logging-controller/src/logTypes/index.ts, message-manager/src/index.ts).
    • Minor string/template/comment fixes to satisfy lint rules.
  • Config/metadata:
    • Update eslint-warning-thresholds.json to reflect fewer rule violations.
  • Tests/Utilities:
    • Align tests and helpers with import/order and readonly changes; minor noop function/type tweaks.

Written by Cursor Bugbot for commit cf8849f. This will update automatically on new commits. Configure here.

Fix all auto-fixable ESLint warnings. These changes were generated by running
`yarn eslint --fix`.

There were a number of blank JSDoc entries added by the initial auto-fix
command, which had to be reverted because the empty blocks generated errors.
Aside from that, everything else ESLint recognized as auto-fixable seems to
have been fixed correctly.
@Gudahtt Gudahtt marked this pull request as ready for review November 10, 2025 18:10
@Gudahtt Gudahtt requested review from a team as code owners November 10, 2025 18:11
cryptodev-2s
cryptodev-2s previously approved these changes Nov 10, 2025
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for taking care of this.

mcmire
mcmire previously approved these changes Nov 10, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Core Platform packages look good.

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@Gudahtt Gudahtt dismissed stale reviews from mcmire and cryptodev-2s via 9b9c6f9 November 10, 2025 18:35
Mrtenz
Mrtenz previously approved these changes Nov 10, 2025
@Gudahtt Gudahtt merged commit 232f0b8 into main Nov 10, 2025
277 of 281 checks passed
@Gudahtt Gudahtt deleted the fix-auto-fixable-eslint-warnings branch November 10, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants