-
-
Notifications
You must be signed in to change notification settings - Fork 256
chore: Fix all auto-fixable ESLint warnings #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix all auto-fixable ESLint warnings. These changes were generated by running `yarn eslint --fix`. There were a number of blank JSDoc entries added by the initial auto-fix command, which had to be reverted because the empty blocks generated errors. Aside from that, everything else ESLint recognized as auto-fixable seems to have been fixed correctly.
cryptodev-2s
previously approved these changes
Nov 10, 2025
Contributor
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for taking care of this.
mcmire
previously approved these changes
Nov 10, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to Core Platform packages look good.
Mrtenz
requested changes
Nov 10, 2025
...es/multichain-api-middleware/src/middlewares/multichainMethodCallValidatorMiddleware.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz
previously approved these changes
Nov 10, 2025
Mrtenz
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix all auto-fixable ESLint warnings. These changes were generated by running
yarn eslint --fix.There were a number of blank JSDoc entries added by the initial auto-fix command, which had to be reverted because the empty blocks generated errors. The JSDoc auto-fix rules also messed up some of our malformated type doc blocks, which were reverted as well (the current invalid syntax isn't good, but we should at least preserve it until we can fix it properly).
I also had to do a manual pass to remove obsolete comments and extra newlines from the auto-fix rule that removed unused ESLint ignore directives.
Aside from that, everything else ESLint recognized as auto-fixable seems to have been fixed correctly.
References
N/A
Checklist
Note
Repo-wide ESLint autofixes: mark private fields as readonly, reorder imports, clean/adjust ESLint disables and JSDoc, switch some re-exports to type-only, and update lint warning thresholds; no functional changes.
readonly(e.g., inApprovalController,RatesController,TokenRatesController,NameController, various providers/controllers/tests).eslint-disablecomments; trim extra newlines and comments.logging-controller/src/logTypes/index.ts,message-manager/src/index.ts).eslint-warning-thresholds.jsonto reflect fewer rule violations.Written by Cursor Bugbot for commit cf8849f. This will update automatically on new commits. Configure here.