Skip to content

Conversation

@tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Nov 12, 2025

Explanation

Add missing modalType field and constant to SubscriptionEligibility

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds optional modalType to SubscriptionEligibility, introduces MODAL_TYPE/ModalType, and updates exports and tests.

  • Types:
    • Add MODAL_TYPE constant and ModalType type in src/types.ts.
    • Extend SubscriptionEligibility with optional modalType field.
  • Exports:
    • Export ModalType and MODAL_TYPE from src/index.ts.
  • Tests:
    • Update SubscriptionController.test.ts to import MODAL_TYPE and include modalType in eligibility mocks.
  • Changelog:
    • Document addition of modalType field and constant in CHANGELOG.md.

Written by Cursor Bugbot for commit 612be7c. This will update automatically on new commits. Configure here.

@tuna1207 tuna1207 marked this pull request as ready for review November 12, 2025 08:19
@tuna1207 tuna1207 requested review from a team as code owners November 12, 2025 08:19
@chaitanyapotti chaitanyapotti merged commit b750f49 into main Nov 12, 2025
282 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/subscription-eligibility-modal-type branch November 12, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants