Skip to content

Conversation

@tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Nov 12, 2025

Explanation

Subscription controller add missing start crypto useTestClock param from lastSelectedPaymentMethod in submitShieldSubscriptionCryptoApproval

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Propagates useTestClock from lastSelectedPaymentMethod to startSubscriptionWithCrypto during submitShieldSubscriptionCryptoApproval, and updates changelog.

  • Subscription Controller:
    • In src/SubscriptionController.ts, submitShieldSubscriptionCryptoApproval now includes useTestClock from lastSelectedPaymentMethod when calling startSubscriptionWithCrypto.
  • Documentation:
    • Update packages/subscription-controller/CHANGELOG.md with an Added entry describing the new useTestClock propagation.

Written by Cursor Bugbot for commit 6d52b62. This will update automatically on new commits. Configure here.

@tuna1207 tuna1207 marked this pull request as ready for review November 12, 2025 13:04
@tuna1207 tuna1207 requested review from a team as code owners November 12, 2025 13:04
@tuna1207 tuna1207 added team-web3auth area-shield Transaction Shield labels Nov 12, 2025
@tuna1207 tuna1207 merged commit 255dcd6 into main Nov 12, 2025
281 checks passed
@tuna1207 tuna1207 deleted the fix/subscription-crypto-use-test-clock branch November 12, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants