fix: trigger access token refresh

[tuna1207]

Explanation

• Previously triggerAccessTokenRefresh was only called during getSubscriptions polling, normal subscription state change didn't trigger it.
  This PR trigger triggerAccessTokenRefresh everytime subscription state change
• Remove triggerAccessTokenRefresh from startShieldSubscriptionWithCard since that only return stripe checkout url, not subscribed yet.

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

---

Note

Refresh access token immediately when subscription state changes and remove redundant refresh triggers in start subscription flows, simplifying poll logic.

• Subscription Controller (src/SubscriptionController.ts):
  • Trigger triggerAccessTokenRefresh() immediately when getSubscriptions updates state; remove deferred flag and poll-based refresh path.
  • Remove triggerAccessTokenRefresh() after startShieldSubscriptionWithCard and startSubscriptionWithCrypto (checkout/creation only), with clarifying comments.
  • _executePoll now only calls getSubscriptions.
• Changelog: Document the above behavior changes under [Unreleased].

^{Written by Cursor Bugbot for commit bc4213d. This will update automatically on new commits. Configure here.}

[cursor]

Bug: Double Refresh Triggers Unnecessary Sign-Out.

triggerAccessTokenRefresh() is called twice in submitShieldSubscriptionCryptoApproval(): once by startSubscriptionWithCrypto() at line 477, and again by getSubscriptions() at line 393 when it detects the subscription state change. This causes redundant performSignOut calls to the AuthenticationController.

packages/subscription-controller/src/SubscriptionController.ts#L530-L533

core/packages/subscription-controller/src/SubscriptionController.ts

Lines 530 to 533 in d305b7e

	};
	await this.startSubscriptionWithCrypto(params);
	// update the subscriptions state after subscription created in server
	await this.getSubscriptions();

 

---