feat: transaction quote source amounts #7159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/transaction-pay-controller/src/strategy/bridge/bridge-quotes.ts
Show resolved
Hide resolved
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
approved these changes
Nov 17, 2025
Add human and raw to source network fee.
matthewwalsh0
force-pushed
the
feat/quote-source-amounts
branch
from
8d5916c to
8e804fb
Compare
packages/transaction-pay-controller/src/strategy/bridge/bridge-quotes.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Include
sourceAmountsinTransactionPayQuoteso the clients can validate the exact source amount is available.Also:
estimateandmaxsource network fee inTransactionPayQuote.References
Checklist
Note
Adds sourceAmount to quotes/totals, exposes estimate and max source network fees (with human/raw), accounts for gas fee tokens in target fees, and fixes USD rates for Polygon USDCe/Arbitrum USDC.
sourceAmounttoTransactionPayQuoteandTransactionPayTotals.fees.sourceNetworkto include{ estimate, max }(each anAmountwithfiat/usd/human/raw).isTargetGasFeeTokentofeesand propagate in totals.sourceAmount; compute source fees asestimateandmax; keep target network fee; refine provider fee for Relay (max of relayer fee vs value loss).calculateGasCost/calculateTransactionGasCostnow returnAmount(fiat/usd/human/raw) and supportisMax.1) for stablecoins on Polygon USDCe and Arbitrum USDC; expose new chain/token constants.Amountshapes (source fees estimate/max, sourceAmount) and setisTargetGasFeeToken.networkFeeFiatusesfees.sourceNetwork.estimate.usd.Written by Cursor Bugbot for commit 8e804fb. This will update automatically on new commits. Configure here.