Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Nov 18, 2025

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds rawTransactionHex to transaction logging and skips coverage checks once a tx is submitted or confirmed; updates types, backend, tests, and changelog.

  • ShieldController:
    • Skip coverage checks when transaction.status is submitted or confirmed.
    • Require txMeta.rawTx; include as rawTransactionHex in #logTransaction payload.
  • Backend:
    • logTransaction now sends rawTransactionHex and aborts pending polls by tx id.
  • Types:
    • Extend LogTransactionRequest with rawTransactionHex.
  • Tests:
    • Update transaction logging tests to include rawTransactionHex and add missing-rawTx case.
    • Adjust backend tests to expect rawTransactionHex.
  • Changelog:
    • Document added transactionMeta.rawTx in logging.
    • Note skipping coverage check for submitted/confirmed transactions.

Written by Cursor Bugbot for commit da0fac2. This will update automatically on new commits. Configure here.

@lwin-kyaw lwin-kyaw requested a review from a team as a code owner November 18, 2025 10:09
@lwin-kyaw lwin-kyaw requested a review from a team as a code owner November 18, 2025 10:10
@lwin-kyaw
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "3.0.0-preview-14f5fa1",
  "@metamask-previews/accounts-controller": "34.0.0-preview-14f5fa1",
  "@metamask-previews/address-book-controller": "7.0.0-preview-14f5fa1",
  "@metamask-previews/analytics-controller": "0.0.0-preview-14f5fa1",
  "@metamask-previews/announcement-controller": "8.0.0-preview-14f5fa1",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-14f5fa1",
  "@metamask-previews/approval-controller": "8.0.0-preview-14f5fa1",
  "@metamask-previews/assets-controllers": "88.0.0-preview-14f5fa1",
  "@metamask-previews/base-controller": "9.0.0-preview-14f5fa1",
  "@metamask-previews/bridge-controller": "60.1.0-preview-14f5fa1",
  "@metamask-previews/bridge-status-controller": "60.1.0-preview-14f5fa1",
  "@metamask-previews/build-utils": "3.0.4-preview-14f5fa1",
  "@metamask-previews/chain-agnostic-permission": "1.2.2-preview-14f5fa1",
  "@metamask-previews/claims-controller": "0.2.0-preview-14f5fa1",
  "@metamask-previews/composable-controller": "12.0.0-preview-14f5fa1",
  "@metamask-previews/controller-utils": "11.15.0-preview-14f5fa1",
  "@metamask-previews/core-backend": "4.1.0-preview-14f5fa1",
  "@metamask-previews/delegation-controller": "1.0.0-preview-14f5fa1",
  "@metamask-previews/earn-controller": "10.0.0-preview-14f5fa1",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-14f5fa1",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-14f5fa1",
  "@metamask-previews/eip1193-permission-middleware": "1.0.2-preview-14f5fa1",
  "@metamask-previews/ens-controller": "18.0.0-preview-14f5fa1",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-14f5fa1",
  "@metamask-previews/eth-block-tracker": "14.0.0-preview-14f5fa1",
  "@metamask-previews/eth-json-rpc-middleware": "21.0.0-preview-14f5fa1",
  "@metamask-previews/eth-json-rpc-provider": "5.0.1-preview-14f5fa1",
  "@metamask-previews/foundryup": "1.0.1-preview-14f5fa1",
  "@metamask-previews/gas-fee-controller": "25.0.0-preview-14f5fa1",
  "@metamask-previews/gator-permissions-controller": "0.4.0-preview-14f5fa1",
  "@metamask-previews/json-rpc-engine": "10.1.1-preview-14f5fa1",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-14f5fa1",
  "@metamask-previews/keyring-controller": "24.0.0-preview-14f5fa1",
  "@metamask-previews/logging-controller": "7.0.0-preview-14f5fa1",
  "@metamask-previews/message-manager": "14.0.0-preview-14f5fa1",
  "@metamask-previews/messenger": "0.3.0-preview-14f5fa1",
  "@metamask-previews/multichain-account-service": "3.0.0-preview-14f5fa1",
  "@metamask-previews/multichain-api-middleware": "1.2.4-preview-14f5fa1",
  "@metamask-previews/multichain-network-controller": "2.0.0-preview-14f5fa1",
  "@metamask-previews/multichain-transactions-controller": "6.0.0-preview-14f5fa1",
  "@metamask-previews/name-controller": "9.0.0-preview-14f5fa1",
  "@metamask-previews/network-controller": "25.0.0-preview-14f5fa1",
  "@metamask-previews/network-enablement-controller": "3.1.0-preview-14f5fa1",
  "@metamask-previews/notification-services-controller": "20.0.0-preview-14f5fa1",
  "@metamask-previews/permission-controller": "12.1.0-preview-14f5fa1",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-14f5fa1",
  "@metamask-previews/phishing-controller": "15.0.1-preview-14f5fa1",
  "@metamask-previews/polling-controller": "15.0.0-preview-14f5fa1",
  "@metamask-previews/preferences-controller": "21.0.0-preview-14f5fa1",
  "@metamask-previews/profile-sync-controller": "26.0.0-preview-14f5fa1",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-14f5fa1",
  "@metamask-previews/remote-feature-flag-controller": "2.0.0-preview-14f5fa1",
  "@metamask-previews/sample-controllers": "3.0.0-preview-14f5fa1",
  "@metamask-previews/seedless-onboarding-controller": "6.1.0-preview-14f5fa1",
  "@metamask-previews/selected-network-controller": "25.0.0-preview-14f5fa1",
  "@metamask-previews/shield-controller": "2.1.0-preview-14f5fa1",
  "@metamask-previews/signature-controller": "36.0.0-preview-14f5fa1",
  "@metamask-previews/subscription-controller": "4.2.2-preview-14f5fa1",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-14f5fa1",
  "@metamask-previews/transaction-controller": "61.3.0-preview-14f5fa1",
  "@metamask-previews/transaction-pay-controller": "7.0.0-preview-14f5fa1",
  "@metamask-previews/user-operation-controller": "40.0.0-preview-14f5fa1"
}

@lwin-kyaw
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "3.0.0-preview-974556b8",
  "@metamask-previews/accounts-controller": "34.0.0-preview-974556b8",
  "@metamask-previews/address-book-controller": "7.0.0-preview-974556b8",
  "@metamask-previews/analytics-controller": "0.0.0-preview-974556b8",
  "@metamask-previews/announcement-controller": "8.0.0-preview-974556b8",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-974556b8",
  "@metamask-previews/approval-controller": "8.0.0-preview-974556b8",
  "@metamask-previews/assets-controllers": "88.0.0-preview-974556b8",
  "@metamask-previews/base-controller": "9.0.0-preview-974556b8",
  "@metamask-previews/bridge-controller": "60.1.0-preview-974556b8",
  "@metamask-previews/bridge-status-controller": "60.1.0-preview-974556b8",
  "@metamask-previews/build-utils": "3.0.4-preview-974556b8",
  "@metamask-previews/chain-agnostic-permission": "1.2.2-preview-974556b8",
  "@metamask-previews/claims-controller": "0.2.0-preview-974556b8",
  "@metamask-previews/composable-controller": "12.0.0-preview-974556b8",
  "@metamask-previews/controller-utils": "11.15.0-preview-974556b8",
  "@metamask-previews/core-backend": "4.1.0-preview-974556b8",
  "@metamask-previews/delegation-controller": "1.0.0-preview-974556b8",
  "@metamask-previews/earn-controller": "10.0.0-preview-974556b8",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-974556b8",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-974556b8",
  "@metamask-previews/eip1193-permission-middleware": "1.0.2-preview-974556b8",
  "@metamask-previews/ens-controller": "18.0.0-preview-974556b8",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-974556b8",
  "@metamask-previews/eth-block-tracker": "14.0.0-preview-974556b8",
  "@metamask-previews/eth-json-rpc-middleware": "21.0.0-preview-974556b8",
  "@metamask-previews/eth-json-rpc-provider": "5.0.1-preview-974556b8",
  "@metamask-previews/foundryup": "1.0.1-preview-974556b8",
  "@metamask-previews/gas-fee-controller": "25.0.0-preview-974556b8",
  "@metamask-previews/gator-permissions-controller": "0.4.0-preview-974556b8",
  "@metamask-previews/json-rpc-engine": "10.1.1-preview-974556b8",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-974556b8",
  "@metamask-previews/keyring-controller": "24.0.0-preview-974556b8",
  "@metamask-previews/logging-controller": "7.0.0-preview-974556b8",
  "@metamask-previews/message-manager": "14.0.0-preview-974556b8",
  "@metamask-previews/messenger": "0.3.0-preview-974556b8",
  "@metamask-previews/multichain-account-service": "3.0.0-preview-974556b8",
  "@metamask-previews/multichain-api-middleware": "1.2.4-preview-974556b8",
  "@metamask-previews/multichain-network-controller": "2.0.0-preview-974556b8",
  "@metamask-previews/multichain-transactions-controller": "6.0.0-preview-974556b8",
  "@metamask-previews/name-controller": "9.0.0-preview-974556b8",
  "@metamask-previews/network-controller": "25.0.0-preview-974556b8",
  "@metamask-previews/network-enablement-controller": "3.1.0-preview-974556b8",
  "@metamask-previews/notification-services-controller": "20.0.0-preview-974556b8",
  "@metamask-previews/permission-controller": "12.1.0-preview-974556b8",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-974556b8",
  "@metamask-previews/phishing-controller": "15.0.1-preview-974556b8",
  "@metamask-previews/polling-controller": "15.0.0-preview-974556b8",
  "@metamask-previews/preferences-controller": "21.0.0-preview-974556b8",
  "@metamask-previews/profile-sync-controller": "26.0.0-preview-974556b8",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-974556b8",
  "@metamask-previews/remote-feature-flag-controller": "2.0.0-preview-974556b8",
  "@metamask-previews/sample-controllers": "3.0.0-preview-974556b8",
  "@metamask-previews/seedless-onboarding-controller": "6.1.0-preview-974556b8",
  "@metamask-previews/selected-network-controller": "25.0.0-preview-974556b8",
  "@metamask-previews/shield-controller": "2.1.0-preview-974556b8",
  "@metamask-previews/signature-controller": "36.0.0-preview-974556b8",
  "@metamask-previews/subscription-controller": "4.2.2-preview-974556b8",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-974556b8",
  "@metamask-previews/transaction-controller": "61.3.0-preview-974556b8",
  "@metamask-previews/transaction-pay-controller": "7.0.0-preview-974556b8",
  "@metamask-previews/user-operation-controller": "40.0.0-preview-974556b8"
}

@lwin-kyaw
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "3.0.0-preview-5c33a25a",
  "@metamask-previews/accounts-controller": "34.0.0-preview-5c33a25a",
  "@metamask-previews/address-book-controller": "7.0.0-preview-5c33a25a",
  "@metamask-previews/analytics-controller": "0.0.0-preview-5c33a25a",
  "@metamask-previews/announcement-controller": "8.0.0-preview-5c33a25a",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-5c33a25a",
  "@metamask-previews/approval-controller": "8.0.0-preview-5c33a25a",
  "@metamask-previews/assets-controllers": "88.0.0-preview-5c33a25a",
  "@metamask-previews/base-controller": "9.0.0-preview-5c33a25a",
  "@metamask-previews/bridge-controller": "60.1.0-preview-5c33a25a",
  "@metamask-previews/bridge-status-controller": "60.1.0-preview-5c33a25a",
  "@metamask-previews/build-utils": "3.0.4-preview-5c33a25a",
  "@metamask-previews/chain-agnostic-permission": "1.2.2-preview-5c33a25a",
  "@metamask-previews/claims-controller": "0.2.0-preview-5c33a25a",
  "@metamask-previews/composable-controller": "12.0.0-preview-5c33a25a",
  "@metamask-previews/controller-utils": "11.15.0-preview-5c33a25a",
  "@metamask-previews/core-backend": "4.1.0-preview-5c33a25a",
  "@metamask-previews/delegation-controller": "1.0.0-preview-5c33a25a",
  "@metamask-previews/earn-controller": "10.0.0-preview-5c33a25a",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-5c33a25a",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-5c33a25a",
  "@metamask-previews/eip1193-permission-middleware": "1.0.2-preview-5c33a25a",
  "@metamask-previews/ens-controller": "18.0.0-preview-5c33a25a",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-5c33a25a",
  "@metamask-previews/eth-block-tracker": "14.0.0-preview-5c33a25a",
  "@metamask-previews/eth-json-rpc-middleware": "21.0.0-preview-5c33a25a",
  "@metamask-previews/eth-json-rpc-provider": "5.0.1-preview-5c33a25a",
  "@metamask-previews/foundryup": "1.0.1-preview-5c33a25a",
  "@metamask-previews/gas-fee-controller": "25.0.0-preview-5c33a25a",
  "@metamask-previews/gator-permissions-controller": "0.4.0-preview-5c33a25a",
  "@metamask-previews/json-rpc-engine": "10.1.1-preview-5c33a25a",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-5c33a25a",
  "@metamask-previews/keyring-controller": "24.0.0-preview-5c33a25a",
  "@metamask-previews/logging-controller": "7.0.0-preview-5c33a25a",
  "@metamask-previews/message-manager": "14.0.0-preview-5c33a25a",
  "@metamask-previews/messenger": "0.3.0-preview-5c33a25a",
  "@metamask-previews/multichain-account-service": "3.0.0-preview-5c33a25a",
  "@metamask-previews/multichain-api-middleware": "1.2.4-preview-5c33a25a",
  "@metamask-previews/multichain-network-controller": "2.0.0-preview-5c33a25a",
  "@metamask-previews/multichain-transactions-controller": "6.0.0-preview-5c33a25a",
  "@metamask-previews/name-controller": "9.0.0-preview-5c33a25a",
  "@metamask-previews/network-controller": "25.0.0-preview-5c33a25a",
  "@metamask-previews/network-enablement-controller": "3.1.0-preview-5c33a25a",
  "@metamask-previews/notification-services-controller": "20.0.0-preview-5c33a25a",
  "@metamask-previews/permission-controller": "12.1.0-preview-5c33a25a",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-5c33a25a",
  "@metamask-previews/phishing-controller": "15.0.1-preview-5c33a25a",
  "@metamask-previews/polling-controller": "15.0.0-preview-5c33a25a",
  "@metamask-previews/preferences-controller": "21.0.0-preview-5c33a25a",
  "@metamask-previews/profile-sync-controller": "26.0.0-preview-5c33a25a",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-5c33a25a",
  "@metamask-previews/remote-feature-flag-controller": "2.0.0-preview-5c33a25a",
  "@metamask-previews/sample-controllers": "3.0.0-preview-5c33a25a",
  "@metamask-previews/seedless-onboarding-controller": "6.1.0-preview-5c33a25a",
  "@metamask-previews/selected-network-controller": "25.0.0-preview-5c33a25a",
  "@metamask-previews/shield-controller": "2.1.0-preview-5c33a25a",
  "@metamask-previews/signature-controller": "36.0.0-preview-5c33a25a",
  "@metamask-previews/subscription-controller": "4.2.2-preview-5c33a25a",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-5c33a25a",
  "@metamask-previews/transaction-controller": "61.3.0-preview-5c33a25a",
  "@metamask-previews/transaction-pay-controller": "7.0.0-preview-5c33a25a",
  "@metamask-previews/user-operation-controller": "40.0.0-preview-5c33a25a"
}

@lwin-kyaw lwin-kyaw added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 68aced1 Nov 18, 2025
273 checks passed
@lwin-kyaw lwin-kyaw deleted the feat/shield-rawTx branch November 18, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants