fix: publish Unified SwapBridge Quotes Received event when tx is submitted #7182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
micaelae
changed the title
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
ghgoodreau
approved these changes
Nov 19, 2025
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Publishes the
QuotesReceivedevent when submitting a trade before all quotes loadExtension PR: MetaMask/metamask-extension#37963
Mobilie PR: MetaMask/metamask-mobile#22905
References
Fixes https://consensyssoftware.atlassian.net/browse/SWAPS-3427
Checklist
Note
Publishes a QuotesReceived event on early trade submission and adds a helper and types to standardize its payload and warnings.
submitTxto accept optionalisLoadingandwarnings; whenisLoading=true, publishUnified SwapBridge Quotes ReceivedusinggetQuotesReceivedPropertiesbefore stopping quote polling.QuotesReceivedin internal tracking helper.getQuotesReceivedPropertiesto build QuotesReceived metrics payload; re-export fromindex.ts.QuoteWarningtype and use it forwarningsacross events/tests; update snapshots to standardized values (e.g.,low_return,insufficient_balance).gasIncludedvsgasIncluded_7702handling and add scenario where fees come from dest token under 7702.undefinedfees on failure) and validate BTC/SOL fee behaviors.Written by Cursor Bugbot for commit 89bb4b5. This will update automatically on new commits. Configure here.