Skip to content

Move peer deps for controller/service packages to direct deps #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 21, 2025
Merged

Move peer deps for controller/service packages to direct deps #7209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5342e97
Move peer deps for controller/service packages to direct deps
mcmire Nov 20, 2025
34dddcb
Merge branch 'main' into convert-peer-deps-to-deps
mcmire Nov 20, 2025
2d47a98
Merge branch 'main' into convert-peer-deps-to-deps
mcmire Nov 20, 2025
6150cf3
Merge branch 'main' into convert-peer-deps-to-deps
mcmire Nov 21, 2025
8a28cfb
Go through one more time
mcmire Nov 21, 2025
22b1cbe
Update lockfile
mcmire Nov 21, 2025
47a5aed
Merge branch 'main' into convert-peer-deps-to-deps
mcmire Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/account-tree-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209))
- The dependencies moved are:
- `@metamask/accounts-controller` (^35.0.0)
- `@metamask/keyring-controller` (^25.0.0)
- `@metamask/multichain-account-service` (^4.0.0)
- `@metamask/profile-sync-controller` (^27.0.0)
- `@metamask/snaps-controllers` (^14.0.1)
- In clients, it is now possible for multiple versions of these packages to exist in the dependency tree.
- For example, this scenario would be valid: a client relies on `@metamask/controller-a` 1.0.0 and `@metamask/controller-b` 1.0.0, and `@metamask/controller-b` depends on `@metamask/controller-a` 1.1.0.
- Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication.

## [4.0.0]

### Changed
Expand Down
16 changes: 5 additions & 11 deletions packages/account-tree-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,13 @@
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/accounts-controller": "^35.0.0",
"@metamask/base-controller": "^9.0.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/messenger": "^0.3.0",
"@metamask/multichain-account-service": "^4.0.0",
"@metamask/profile-sync-controller": "^27.0.0",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/superstruct": "^3.1.0",
Expand All @@ -59,14 +64,9 @@
},
"devDependencies": {
"@metamask/account-api": "^0.12.0",
"@metamask/accounts-controller": "^35.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/keyring-api": "^21.0.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/multichain-account-service": "^4.0.0",
"@metamask/profile-sync-controller": "^27.0.0",
"@metamask/providers": "^22.1.0",
"@metamask/snaps-controllers": "^14.0.1",
"@ts-bridge/cli": "^0.6.4",
"@types/jest": "^27.4.1",
"deepmerge": "^4.2.2",
Expand All @@ -78,13 +78,7 @@
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/account-api": "^0.12.0",
"@metamask/accounts-controller": "^35.0.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/multichain-account-service": "^4.0.0",
"@metamask/profile-sync-controller": "^27.0.0",
"@metamask/providers": "^22.0.0",
"@metamask/snaps-controllers": "^14.0.0",
"webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0"
},
"engines": {
Expand Down
11 changes: 11 additions & 0 deletions packages/accounts-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209))
- The dependencies moved are:
- `@metamask/keyring-controller` (^25.0.0)
- `@metamask/network-controller` (^26.0.0)
- `@metamask/snaps-controllers` (^14.0.1)
- In clients, it is now possible for multiple versions of these packages to exist in the dependency tree.
- For example, this scenario would be valid: a client relies on `@metamask/controller-a` 1.0.0 and `@metamask/controller-b` 1.0.0, and `@metamask/controller-b` depends on `@metamask/controller-a` 1.1.0.
- Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication.

## [35.0.0]

### Changed
Expand Down
9 changes: 3 additions & 6 deletions packages/accounts-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@
"@metamask/base-controller": "^9.0.0",
"@metamask/eth-snap-keyring": "^18.0.0",
"@metamask/keyring-api": "^21.0.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/keyring-internal-api": "^9.0.0",
"@metamask/keyring-utils": "^3.1.0",
"@metamask/messenger": "^0.3.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/superstruct": "^3.1.0",
Expand All @@ -68,10 +71,7 @@
"devDependencies": {
"@metamask/auto-changelog": "^3.4.4",
"@metamask/controller-utils": "^11.16.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/providers": "^22.1.0",
"@metamask/snaps-controllers": "^14.0.1",
"@ts-bridge/cli": "^0.6.4",
"@types/jest": "^27.4.1",
"@types/readable-stream": "^2.3.0",
Expand All @@ -83,10 +83,7 @@
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/keyring-controller": "^25.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/providers": "^22.0.0",
"@metamask/snaps-controllers": "^14.0.0",
"webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0"
},
"engines": {
Expand Down
21 changes: 21 additions & 0 deletions packages/assets-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- JWT token is included in `Authorization: Bearer <token>` header when provided
- Backward compatible: token parameter is optional and APIs work without authentication

### Changed

- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209))
- The dependencies moved are:
- `@metamask/account-tree-controller` (^4.0.0)
- `@metamask/accounts-controller` (^35.0.0)
- `@metamask/approval-controller` (^8.0.0)
- `@metamask/core-backend` (^5.0.0)
- `@metamask/keyring-controller` (^25.0.0)
- `@metamask/multichain-account-service` (^4.0.0)
- `@metamask/network-controller` (^26.0.0)
- `@metamask/permission-controller` (^12.1.1)
- `@metamask/phishing-controller` (^16.1.0)
- `@metamask/preferences-controller` (^22.0.0)
- `@metamask/profile-sync-controller` (^27.0.0)
- `@metamask/snaps-controllers` (^14.0.1)
- `@metamask/transaction-controller` (^62.1.0)
- In clients, it is now possible for multiple versions of these packages to exist in the dependency tree.
- For example, this scenario would be valid: a client relies on `@metamask/controller-a` 1.0.0 and `@metamask/controller-b` 1.0.0, and `@metamask/controller-b` depends on `@metamask/controller-a` 1.1.0.
- Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication.

### Fixed

- `TokenBalancesController`: state inconsistency by ensuring all account addresses are stored in lowercase format ([#7216](https://github.com/MetaMask/core/pull/7216))
Expand Down
38 changes: 13 additions & 25 deletions packages/assets-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,30 @@
"@ethersproject/contracts": "^5.7.0",
"@ethersproject/providers": "^5.7.0",
"@metamask/abi-utils": "^2.0.3",
"@metamask/account-tree-controller": "^4.0.0",
"@metamask/accounts-controller": "^35.0.0",
"@metamask/approval-controller": "^8.0.0",
"@metamask/base-controller": "^9.0.0",
"@metamask/contract-metadata": "^2.4.0",
"@metamask/controller-utils": "^11.16.0",
"@metamask/core-backend": "^5.0.0",
"@metamask/eth-query": "^4.0.0",
"@metamask/keyring-api": "^21.0.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/messenger": "^0.3.0",
"@metamask/metamask-eth-abis": "^3.1.1",
"@metamask/multichain-account-service": "^4.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/permission-controller": "^12.1.1",
"@metamask/phishing-controller": "^16.1.0",
"@metamask/polling-controller": "^16.0.0",
"@metamask/preferences-controller": "^22.0.0",
"@metamask/profile-sync-controller": "^27.0.0",
"@metamask/rpc-errors": "^7.0.2",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/transaction-controller": "^62.1.0",
"@metamask/utils": "^11.8.1",
"@types/bn.js": "^5.1.5",
"@types/uuid": "^8.3.0",
Expand All @@ -82,24 +95,11 @@
"devDependencies": {
"@babel/runtime": "^7.23.9",
"@metamask/account-api": "^0.12.0",
"@metamask/account-tree-controller": "^4.0.0",
"@metamask/accounts-controller": "^35.0.0",
"@metamask/approval-controller": "^8.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/core-backend": "^5.0.0",
"@metamask/ethjs-provider-http": "^0.3.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/keyring-internal-api": "^9.0.0",
"@metamask/keyring-snap-client": "^8.0.0",
"@metamask/multichain-account-service": "^4.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/permission-controller": "^12.1.1",
"@metamask/phishing-controller": "^16.1.0",
"@metamask/preferences-controller": "^22.0.0",
"@metamask/profile-sync-controller": "^27.0.0",
"@metamask/providers": "^22.1.0",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/transaction-controller": "^62.1.0",
"@ts-bridge/cli": "^0.6.4",
"@types/jest": "^27.4.1",
"@types/lodash": "^4.14.191",
Expand All @@ -116,19 +116,7 @@
"webextension-polyfill": "^0.12.0"
},
"peerDependencies": {
"@metamask/account-tree-controller": "^4.0.0",
"@metamask/accounts-controller": "^35.0.0",
"@metamask/approval-controller": "^8.0.0",
"@metamask/core-backend": "^5.0.0",
"@metamask/keyring-controller": "^25.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/permission-controller": "^12.0.0",
"@metamask/phishing-controller": "^16.0.0",
"@metamask/preferences-controller": "^22.0.0",
"@metamask/profile-sync-controller": "^27.0.0",
"@metamask/providers": "^22.0.0",
"@metamask/snaps-controllers": "^14.0.0",
"@metamask/transaction-controller": "^62.0.0",
"webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0"
},
"engines": {
Expand Down
14 changes: 14 additions & 0 deletions packages/bridge-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209))
- The dependencies moved are:
- `@metamask/accounts-controller` (^35.0.0)
- `@metamask/assets-controllers` (^91.0.0)
- `@metamask/network-controller` (^26.0.0)
- `@metamask/remote-feature-flag-controller` (^2.0.1)
- `@metamask/snaps-controllers` (^14.0.0)
- `@metamask/transaction-controller` (^62.1.0)
- In clients, it is now possible for multiple versions of these packages to exist in the dependency tree.
- For example, this scenario would be valid: a client relies on `@metamask/controller-a` 1.0.0 and `@metamask/controller-b` 1.0.0, and `@metamask/controller-b` depends on `@metamask/controller-a` 1.1.0.
- Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication.

## [63.0.0]

### Changed
Expand Down
20 changes: 6 additions & 14 deletions packages/bridge-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,29 +53,29 @@
"@ethersproject/constants": "^5.7.0",
"@ethersproject/contracts": "^5.7.0",
"@ethersproject/providers": "^5.7.0",
"@metamask/accounts-controller": "^35.0.0",
"@metamask/assets-controllers": "^91.0.0",
"@metamask/base-controller": "^9.0.0",
"@metamask/controller-utils": "^11.16.0",
"@metamask/gas-fee-controller": "^26.0.0",
"@metamask/keyring-api": "^21.0.0",
"@metamask/messenger": "^0.3.0",
"@metamask/metamask-eth-abis": "^3.1.1",
"@metamask/multichain-network-controller": "^3.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/polling-controller": "^16.0.0",
"@metamask/remote-feature-flag-controller": "^2.0.1",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/transaction-controller": "^62.1.0",
"@metamask/utils": "^11.8.1",
"bignumber.js": "^9.1.2",
"reselect": "^5.1.1",
"uuid": "^8.3.2"
},
"devDependencies": {
"@metamask/accounts-controller": "^35.0.0",
"@metamask/assets-controllers": "^91.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/eth-json-rpc-provider": "^6.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/remote-feature-flag-controller": "^2.0.1",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/superstruct": "^3.1.0",
"@metamask/transaction-controller": "^62.1.0",
"@ts-bridge/cli": "^0.6.4",
"@types/jest": "^27.4.1",
"deepmerge": "^4.2.2",
Expand All @@ -88,14 +88,6 @@
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.3.3"
},
"peerDependencies": {
"@metamask/accounts-controller": "^35.0.0",
"@metamask/assets-controllers": "^91.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/remote-feature-flag-controller": "^2.0.0",
"@metamask/snaps-controllers": "^14.0.0",
"@metamask/transaction-controller": "^62.0.0"
},
"engines": {
"node": "^18.18 || >=20"
},
Expand Down
14 changes: 14 additions & 0 deletions packages/bridge-status-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209))
- The dependencies moved are:
- `@metamask/accounts-controller` (^35.0.0)
- `@metamask/bridge-controller` (^63.0.0)
- `@metamask/gas-fee-controller` (^26.0.0)
- `@metamask/network-controller` (^26.0.0)
- `@metamask/snaps-controllers` (^14.0.1)
- `@metamask/transaction-controller` (^62.1.0)
- In clients, it is now possible for multiple versions of these packages to exist in the dependency tree.
- For example, this scenario would be valid: a client relies on `@metamask/controller-a` 1.0.0 and `@metamask/controller-b` 1.0.0, and `@metamask/controller-b` depends on `@metamask/controller-a` 1.1.0.
- Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication.

## [63.0.0]

### Changed
Expand Down
20 changes: 6 additions & 14 deletions packages/bridge-status-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,22 @@
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/accounts-controller": "^35.0.0",
"@metamask/base-controller": "^9.0.0",
"@metamask/bridge-controller": "^63.0.0",
"@metamask/controller-utils": "^11.16.0",
"@metamask/gas-fee-controller": "^26.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/polling-controller": "^16.0.0",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/superstruct": "^3.1.0",
"@metamask/transaction-controller": "^62.1.0",
"@metamask/utils": "^11.8.1",
"bignumber.js": "^9.1.2",
"uuid": "^8.3.2"
},
"devDependencies": {
"@metamask/accounts-controller": "^35.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/bridge-controller": "^63.0.0",
"@metamask/gas-fee-controller": "^26.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/transaction-controller": "^62.1.0",
"@ts-bridge/cli": "^0.6.4",
"@types/jest": "^27.4.1",
"deepmerge": "^4.2.2",
Expand All @@ -76,14 +76,6 @@
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.3.3"
},
"peerDependencies": {
"@metamask/accounts-controller": "^35.0.0",
"@metamask/bridge-controller": "^63.0.0",
"@metamask/gas-fee-controller": "^26.0.0",
"@metamask/network-controller": "^26.0.0",
"@metamask/snaps-controllers": "^14.0.0",
"@metamask/transaction-controller": "^62.0.0"
},
"engines": {
"node": "^18.18 || >=20"
},
Expand Down
10 changes: 10 additions & 0 deletions packages/core-backend/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209))
- The dependencies moved are:
- `@metamask/accounts-controller` (^35.0.0)
- `@metamask/keyring-controller` (^25.0.0)
- In clients, it is now possible for multiple versions of these packages to exist in the dependency tree.
- For example, this scenario would be valid: a client relies on `@metamask/controller-a` 1.0.0 and `@metamask/controller-b` 1.0.0, and `@metamask/controller-b` depends on `@metamask/controller-a` 1.1.0.
- Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication.

## [5.0.0]

### Changed
Expand Down
Loading
Loading