feat: handle subscription payment method change transaction #7231
+175
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lwin-kyaw
reviewed
Nov 25, 2025
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
chaitanyapotti
approved these changes
Nov 27, 2025
chaitanyapotti
deleted the
feat/handle-shield-change-payment-method-transaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR update subscription controller
submitShieldSubscriptionCryptoApprovalmethod to handle change payment method if subscription already exist.References
Checklist
Note
Updates Shield crypto-approval flow to update payment method when a subscription exists and validates subscription status before proceeding.
SHIELDsubscription, and callsupdatePaymentMethod(crypto) with tx data; otherwise starts a new crypto subscription; refreshes state afterward.#assertValidSubscriptionStateForCryptoApprovalto allow only specificSubscriptionStatusvalues; introduces errorSubscriptionNotValidForCryptoApprovaland wiresSUBSCRIPTION_STATUSES/SubscriptionStatus.Written by Cursor Bugbot for commit 93c103b. This will update automatically on new commits. Configure here.