refactor: move Swaps QuoteReceived event publishing to bridge-controller #7242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bfullam
approved these changes
Nov 26, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
## Explanation Releasing this PR: #7242 <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs) - [x] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Publishes bridge-controller 63.2.0 (metrics context in stopPollingForQuotes) and bumps dependent packages, updating monorepo to 695.0.0. > > - **Release**: > - Bump monorepo to `695.0.0`. > - **@metamask/bridge-controller (63.2.0)**: > - `stopPollingForQuotes` accepts metrics context; if quotes still loading, publishes `Unified SwapBridge Quotes Received` before cancel. > - **Dependencies/Consumers**: > - `@metamask/bridge-status-controller` → depend on `@metamask/bridge-controller@^63.2.0` and release `63.1.0`. > - `@metamask/transaction-pay-controller` → bump to `@metamask/bridge-controller@^63.2.0` and `@metamask/bridge-status-controller@^63.1.0`. > - Update `yarn.lock` accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit dae09f3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Publishes QuotesReceived event through BridgeController when quote polling stops on submit to ensure it happens before navigation resets the state
References
Checklist
Note
Routes QuotesReceived publishing through BridgeController when polling stops on submit; submitTx now passes context; adds TransactionSubmitted abort reason and improves logging.
stopPollingForQuotes(reason?, context?)to optionally publishUnified SwapBridge Quotes Receivedif quotes are still loading before abort; acceptAbortReasonand metric context.AbortReason.TransactionSubmitted; ignore it in fetch error early-returns; exportAbortReason.eventNameintrackUnifiedSwapBridgeEventcatch.submitTxsignature to acceptquotesReceivedContextand callBridgeController:stopPollingForQuotes(AbortReason.TransactionSubmitted, context)instead of publishingQuotesReceiveddirectly.#trackUnifiedSwapBridgeEventgeneric to excludeQuotesReceived.Written by Cursor Bugbot for commit 1506266. This will update automatically on new commits. Configure here.