Skip to content

Removing Rinkeby, Ropsten, and Kovan (testnet deprecation) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Removing Rinkeby, Ropsten, and Kovan (testnet deprecation) #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/prefix-for-chain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,9 @@ export = function getPrefixForChain(chainId: string): string | null {
case '0x1': // main net
prefix = '';
break;
case '0x3': // ropsten test net
prefix = 'ropsten.';
break;
case '0x4': // rinkeby test net
prefix = 'rinkeby.';
break;
case '0x5': // goerli test net
prefix = 'goerli.';
break;
case '0x2a': // kovan test net
prefix = 'kovan.';
break;
case '0xaa36a7': // sepolia test net
prefix = 'sepolia.';
break;
Expand Down
9 changes: 0 additions & 9 deletions src/prefix-for-network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,9 @@ export = function getPrefixForNetwork(networkId: string): string | null {
case 1: // main net
prefix = '';
break;
case 3: // ropsten test net
prefix = 'ropsten.';
break;
case 4: // rinkeby test net
prefix = 'rinkeby.';
break;
case 5: // goerli test net
prefix = 'goerli.';
break;
case 42: // kovan test net
prefix = 'kovan.';
break;
default:
prefix = null;
}
Expand Down
68 changes: 34 additions & 34 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ describe('account-link', function () {
assert.strictEqual(result, 'https://etherscan.io/address/foo', 'should handle mainnet');
});

it('should handle ropsten correctly', function () {
const result = createAccountLink('foo', '3');
assert.strictEqual(result, 'https://ropsten.etherscan.io/address/foo', 'should handle ropsten');
it('should handle goerli correctly', function () {
const result = createAccountLink('foo', '5');
assert.strictEqual(result, 'https://goerli.etherscan.io/address/foo', 'should handle goerli');
});

it('should have null as a prefix', function () {
Expand All @@ -39,9 +39,9 @@ describe('account-link', function () {
assert.strictEqual(result, 'https://etherscan.io/address/foo', 'should handle mainnet');
});

it('should handle ropsten correctly', function () {
const result = createAccountLinkForChain('foo', '0x3');
assert.strictEqual(result, 'https://ropsten.etherscan.io/address/foo', 'should handle ropsten');
it('should handle goerli correctly', function () {
const result = createAccountLinkForChain('foo', '0x5');
assert.strictEqual(result, 'https://goerli.etherscan.io/address/foo', 'should handle goerli');
});

it('should have null as a prefix', function () {
Expand Down Expand Up @@ -69,8 +69,8 @@ describe('account-link', function () {
address: '0xabcd',
},
{
expected: 'https://ropsten.etherscan.io/address/0xdef0',
chainId: '0x3',
expected: 'https://goerli.etherscan.io/address/0xdef0',
chainId: '0x5',
address: '0xdef0',
rpcPrefs: {},
},
Expand Down Expand Up @@ -108,9 +108,9 @@ describe('explorer-link', function () {
assert.strictEqual(result, 'https://etherscan.io/tx/foo', 'should handle mainnet');
});

it('should handle ropsten correctly', function () {
const result = createExplorerLink('foo', '3');
assert.strictEqual(result, 'https://ropsten.etherscan.io/tx/foo', 'should handle ropsten');
it('should handle goerli correctly', function () {
const result = createExplorerLink('foo', '5');
assert.strictEqual(result, 'https://goerli.etherscan.io/tx/foo', 'should handle goerli');
});

it('should have null as a prefix', function () {
Expand All @@ -125,9 +125,9 @@ describe('explorer-link', function () {
assert.strictEqual(result, 'https://etherscan.io/tx/foo', 'should handle mainnet');
});

it('should handle ropsten correctly', function () {
const result = createExplorerLinkForChain('foo', '0x3');
assert.strictEqual(result, 'https://ropsten.etherscan.io/tx/foo', 'should handle ropsten');
it('should handle goerli correctly', function () {
const result = createExplorerLinkForChain('foo', '0x5');
assert.strictEqual(result, 'https://goerli.etherscan.io/tx/foo', 'should handle goerli');
});

it('should have null as a prefix', function () {
Expand All @@ -154,19 +154,19 @@ describe('token-tracker-link', function () {
assert.strictEqual(result, 'https://etherscan.io/token/foo', 'should handle mainnet');
});

it('should handle ropsten correctly (no account)', function () {
const result = createTokenTrackerLink('foo', '3');
assert.strictEqual(result, 'https://ropsten.etherscan.io/token/foo', 'should handle ropsten');
it('should handle goerli correctly (no account)', function () {
const result = createTokenTrackerLink('foo', '5');
assert.strictEqual(result, 'https://goerli.etherscan.io/token/foo', 'should handle goerli');
});

it('should handle mainnet correctly (account)', function () {
const result = createTokenTrackerLink('foo', '1', '0xabc');
assert.strictEqual(result, 'https://etherscan.io/token/foo?a=0xabc', 'should handle mainnet');
});

it('should handle ropsten correctly (account)', function () {
const result = createTokenTrackerLink('foo', '3', '0xabc');
assert.strictEqual(result, 'https://ropsten.etherscan.io/token/foo?a=0xabc', 'should handle ropsten');
it('should handle goerli correctly (account)', function () {
const result = createTokenTrackerLink('foo', '5', '0xabc');
assert.strictEqual(result, 'https://goerli.etherscan.io/token/foo?a=0xabc', 'should handle goerli');
});

it('should null has a prefix', function () {
Expand All @@ -181,19 +181,19 @@ describe('token-tracker-link', function () {
assert.strictEqual(result, 'https://etherscan.io/token/foo', 'should handle mainnet');
});

it('should handle ropsten correctly (no account)', function () {
const result = createTokenTrackerLinkForChain('foo', '0x3');
assert.strictEqual(result, 'https://ropsten.etherscan.io/token/foo', 'should handle ropsten');
it('should handle goerli correctly (no account)', function () {
const result = createTokenTrackerLinkForChain('foo', '0x5');
assert.strictEqual(result, 'https://goerli.etherscan.io/token/foo', 'should handle goerli');
});

it('should handle mainnet correctly (account)', function () {
const result = createTokenTrackerLinkForChain('foo', '0x1', '0xabc');
assert.strictEqual(result, 'https://etherscan.io/token/foo?a=0xabc', 'should handle mainnet');
});

it('should handle ropsten correctly (account)', function () {
const result = createTokenTrackerLinkForChain('foo', '0x3', '0xabc');
assert.strictEqual(result, 'https://ropsten.etherscan.io/token/foo?a=0xabc', 'should handle ropsten');
it('should handle goerli correctly (account)', function () {
const result = createTokenTrackerLinkForChain('foo', '0x5', '0xabc');
assert.strictEqual(result, 'https://goerli.etherscan.io/token/foo?a=0xabc', 'should handle goerli');
});

it('should null has a prefix', function () {
Expand All @@ -216,8 +216,8 @@ describe('token-tracker-link', function () {
tokenAddress: '0xabcd',
},
{
expected: 'https://ropsten.etherscan.io/token/0xdef0',
networkId: '3',
expected: 'https://goerli.etherscan.io/token/0xdef0',
networkId: '5',
tokenAddress: '0xdef0',
},
{
Expand All @@ -242,8 +242,8 @@ describe('token-tracker-link', function () {
tokenAddress: '0xabcd',
},
{
expected: 'https://ropsten.etherscan.io/token/0xdef0',
chainId: '0x3',
expected: 'https://goerli.etherscan.io/token/0xdef0',
chainId: '0x5',
tokenAddress: '0xdef0',
rpcPrefs: {},
},
Expand Down Expand Up @@ -293,9 +293,9 @@ describe('token-tracker-link', function () {
},
},
{
expected: 'https://ropsten.etherscan.io/tx/0xdef0',
expected: 'https://goerli.etherscan.io/tx/0xdef0',
transaction: {
metamaskNetworkId: '3',
metamaskNetworkId: '5',
hash: '0xdef0',
},
rpcPrefs: {},
Expand Down Expand Up @@ -330,9 +330,9 @@ describe('token-tracker-link', function () {
},
},
{
expected: 'https://ropsten.etherscan.io/tx/0xdef0',
expected: 'https://goerli.etherscan.io/tx/0xdef0',
transaction: {
chainId: '0x3',
chainId: '0x5',
hash: '0xdef0',
},
rpcPrefs: {},
Expand Down