refactor!: Migrate remaining release-related workflows to actions #168
+382
−381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Mrtenz
force-pushed
the
mrtenz/migrate-project-management-workflows
branch
from
e8f8d8b to
30450de
Compare
Mrtenz
force-pushed
the
mrtenz/migrate-remaining-release-workflows
branch
from
f4d3e2c to
b61fe17
Compare
Mrtenz
changed the base branch from
mrtenz/migrate-project-management-workflows
to
main
Mrtenz
force-pushed
the
mrtenz/migrate-remaining-release-workflows
branch
from
b61fe17 to
5ca3409
Compare
This was referenced Nov 24, 2025
github-merge-queue bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Nov 24, 2025
Migrates some GH workflows to reusable actions. follow-up PR of these: - MetaMask/github-tools#169 - MetaMask/github-tools#168 <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Migrates CI workflows from reusable workflows to explicit action steps and adds manual dispatch triggers where applicable. > > - **Workflows**: > - **`check-pr-max-lines.yml`**: > - Replace reusable workflow with action `MetaMask/github-tools/.github/actions/pr-line-check@v1`. > - Add `runs-on: ubuntu-latest`; configure `max-lines` and `ignore-patterns`. > - **`flaky-test-report.yml`**: > - Replace reusable workflow with action `.../flaky-test-report@v1`. > - Add `workflow_dispatch`; set `runs-on`; pass `repository`, `workflow-id`, `github-token`, and Slack webhook. > - **`post-merge-validation.yml`**: > - Replace reusable workflow with action `.../post-merge-validation@v1`. > - Add `workflow_dispatch`; set `runs-on`; pass `repo`, `start-hour-utc`, `github-token`, and GCP creds. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit dc5e870. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Nov 24, 2025
Migrates some GH workflows to reusable actions. follow-up PR of these: - MetaMask/github-tools#169 - MetaMask/github-tools#168 <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/38174?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Migrates three GitHub workflows from reusable workflows to MetaMask reusable actions, adds manual triggers where applicable, and updates inputs to kebab-case with explicit runners. > > - **CI workflows migrated to reusable actions**: > - `check-pr-max-lines`: Replace reusable workflow with `MetaMask/github-tools/.github/actions/pr-line-check@v1`; add `runs-on: ubuntu-latest`; update inputs to kebab-case (`max-lines`, `ignore-patterns`). > - `flaky-test-report`: Add `workflow_dispatch`; replace reusable workflow with `.../actions/flaky-test-report@v1`; add `runs-on`; pass inputs via `with` (including `workflow-id`, `github-token`, `slack-webhook-flaky-tests`). > - `post-merge-validation`: Add `workflow_dispatch`; replace reusable workflow with `.../actions/post-merge-validation@v1`; add `runs-on`; update inputs (`start-hour-utc`, `github-token`, `google-application-creds-base64`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 148bb80. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://codespaces.new/MetaMask/metamask-extension/pull/38174?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the remaining release-related workflows to actions.
Note
Migrates release-related workflows to new reusable composite actions and updates the stable-sync workflow to use them.
./.github/actions/create-release-pr: Creates platform-specific release PRs (mobile/extension), invokescreate-platform-release-pr.sh, and uploadscommits.csvif present../.github/actions/post-merge-validation: Runs the post-merge validation tracker and updates a Google Sheet../.github/actions/stable-sync: Syncsstabletomainfor a given semver, prepares env (Node/Corepack), runsstable-sync.js, pushes branch, and opens PR if needed../.github/workflows/create-release-pr.ymland./.github/workflows/post-merge-validation.yml../.github/workflows/stable-sync.ymlto use the new composite action, update checkout toactions/checkout@v5, and drop inline steps/extra inputs.Written by Cursor Bugbot for commit 5ca3409. This will update automatically on new commits. Configure here.