Skip to content

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Oct 8, 2025

Description

  • Update scope guides to link to their respective reference docs, clarifying allowedCalldata and exactCalldata where applicable.
  • Update reference examples to include allowedCalldata and exactCalldata where applicable.

Issue(s) fixed

Fixes #2318

Preview

Checklist

  • If this PR updates or adds documentation content that changes or adds technical meaning, it has received an approval from an engineer or DevRel from the relevant team.
  • If this PR updates or adds documentation content, it has received an approval from a technical writer.

Note

Clarifies delegation scope parameters across guides and reference, adds allowed/exact calldata details and examples, and links guides to their scope references.

  • Guides:
    • Function call: Clarifies targets/selectors; documents internal caveat enforcers; adds link to reference/delegation/delegation-scopes.md#function-call-scope; expands example to include to, from, and environment; adds sections with examples for allowedCalldata and exactCalldata.
    • Spending limits: Refines wording; adds links to each scope’s reference; clarifies native token scopes default exactCalldata to 0x and optionally support allowedCalldata/exactCalldata; fixes minor phrasing (time-based).
    • Ownership transfer: Notes internal enforcer and links to reference/delegation/delegation-scopes.md#ownership-transfer-scope.
  • Reference:
    • Caveats: Normalizes wording around calldata (drops superfluous backticks) and minor description tweaks.
    • Delegation scopes: Expands parameter docs for allowedCalldata/exactCalldata (including defaults and selector constraints); tidies examples/comments.

Written by Cursor Bugbot for commit a3d54e0. This will update automatically on new commits. Configure here.

@alexandratran alexandratran requested review from a team as code owners October 8, 2025 23:40
Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
metamask-docs Ready Ready Preview Comment Oct 14, 2025 7:42pm

cursor[bot]

This comment was marked as outdated.

AyushBherwani1998 and others added 3 commits October 14, 2025 12:26
* improve the function call scope guide

* Apply suggestions from code review

---------

Co-authored-by: AyushBherwani1998 <“ayush.bherwani1998@gmail.com”>
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
# Conflicts:
#	delegation-toolkit/reference/delegation/delegation-scopes.md
Copy link
Member

@AyushBherwani1998 AyushBherwani1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 3a231de into main Oct 14, 2025
19 checks passed
@alexandratran alexandratran deleted the 2318-improve-scope-guides branch October 14, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve scope guides

2 participants