Skip to content

Conversation

@alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Nov 19, 2025

Description

  • Update all remaining CardList hrefs to absolute URL paths. This is the simplest way to fix the inconsistent CardList link behavior on Vercel deployments, as absolute links consistently work, while relative links have inconsistent and unpredictable behavior.
  • Update contribution guide with info on formatting links.
  • Fix some other new link errors and update linkspector config for false positives.

Issue(s) fixed

Fixes #2475

Preview

https://metamask-docs-au1c2h7pp-consensys-ddffed67.vercel.app/smart-accounts-kit

Checklist

  • If this PR updates or adds documentation content that changes or adds technical meaning, it has received an approval from an engineer or DevRel from the relevant team.
  • If this PR updates or adds documentation content, it has received an approval from a technical writer.

External contributor checklist

  • I've read the contribution guidelines.
  • I've created a new issue (or assigned myself to an existing issue) describing what this PR addresses.

Note

Converts CardList links to absolute paths across docs, updates CONTRIBUTING with link formatting guidance, and tweaks link checker ignores and external URLs.

  • Docs:
    • Update CardList href values to absolute paths across developer-tools, smart-accounts-kit (and versioned gator_versioned_docs), and multiple services/reference/* index pages.
    • Edit CONTRIBUTING.md:
      • Add "Format links" section clarifying relative vs absolute and CardList usage.
      • Update content directories and sidebar files list; revise image directories.
    • Fix external links: ConnectKit docs URL; 0xFury privacy policy URLs.
  • Tooling/Config:
    • .linkspector.yml: add ignore patterns for https://web3onboard.thirdweb.com and https://0xfury.com/privacy.

Written by Cursor Bugbot for commit 5973391. This will update automatically on new commits. Configure here.

@alexandratran alexandratran requested review from a team as code owners November 19, 2025 02:59
@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
metamask-docs Ready Ready Preview Comment Nov 19, 2025 3:36am

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran alexandratran merged commit 1a90245 into main Nov 19, 2025
16 of 18 checks passed
@alexandratran alexandratran deleted the fix-links branch November 19, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link on https://docs.metamask.io/services/reference/ethereum

3 participants