Skip to content

Conversation

@legobeat
Copy link

@legobeat legobeat commented May 3, 2024

This is the release candidate for @metamask/react-native-payments v2.0.1

Changes

@legobeat legobeat requested review from a team and Cal-L May 3, 2024 22:49
@legobeat legobeat merged commit abf39ba into main May 30, 2024
@legobeat
Copy link
Author

@wachunei I noticed when publishing that tests are failing:

$ jest
 FAIL  lib/js/errors/__tests__/index-test.js
  ● Test suite failed to run

    /app/lib/js/errors/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import ExtendableError from 'es6-error';
                                                                                             ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at new Script (node:vm:116:7)
      at Object.<anonymous> (lib/js/errors/__tests__/index-test.js:1:115)

 FAIL  lib/js/helpers/__tests__/index-test.js
  ● Test suite failed to run

    /app/lib/js/helpers/index.js: Unexpected token (1:12)
      > 1 | import type {
          |             ^
        2 |   PaymentDetailsInit,
        3 |   PaymentItem,
        4 |   PaymentShippingOption

Test Suites: 2 failed, 2 total
Tests:       0 total
Snapshots:   0 total
Time:        1.774s
Ran all test suites.
error Command failed with exit code 1.

I get the same on v2.0.0 as well, so proceeding with publish.

@legobeat
Copy link
Author

npm notice package: @metamask/react-native-payments@2.0.1
npm notice === Tarball Contents ===
npm notice 1.1kB  .github/workflows/security-code-scanner.yml
npm notice 152B   .travis.yml
npm notice 18.5kB README.md
npm notice 705B   android/build.gradle
npm notice 128B   android/src/main/AndroidManifest.xml
npm notice 16.5kB android/src/main/java/com/reactnativepayments/ReactNativePaymentsModule.java
npm notice 913B   android/src/main/java/com/reactnativepayments/ReactNativePaymentsPackage.java
npm notice 1.3kB  lib/ios/GatewayManager.h
npm notice 3.6kB  lib/ios/GatewayManager.m
npm notice 1.8kB  lib/ios/ReactNativePayments.h
npm notice 21.7kB lib/ios/ReactNativePayments.m
npm notice 700B   lib/ios/ReactNativePayments.podspec
npm notice 10.7kB lib/ios/ReactNativePayments.xcodeproj/project.pbxproj
npm notice 135B   lib/ios/ReactNativePayments.xcodeproj/project.xcworkspace/contents.xcworkspacedata
npm notice 257B   lib/ios/Views/PKPaymentButtonManager.h
npm notice 735B   lib/ios/Views/PKPaymentButtonManager.m
npm notice 483B   lib/ios/Views/PKPaymentButtonView.h
npm notice 2.5kB  lib/ios/Views/PKPaymentButtonView.m
npm notice 832B   lib/js/__mocks__/index.js
npm notice 745B   lib/js/constants.js
npm notice 1.2kB  lib/js/errors/index.js
npm notice 8.6kB  lib/js/helpers/index.js
npm notice 318B   lib/js/index.js
npm notice 4.8kB  lib/js/NativePayments.js
npm notice 16.2kB lib/js/PaymentRequest.js
npm notice 8.5kB  lib/js/PaymentRequestUpdateEvent.js
npm notice 2.5kB  lib/js/PaymentResponse.js
npm notice 1.5kB  lib/js/PKPaymentButton.js
npm notice 3.0kB  lib/js/types.js
npm notice 1.2kB  package.json
npm notice === Tarball Details ===
npm notice name:          @metamask/react-native-payments
npm notice version:       2.0.1
npm notice filename:      metamask-react-native-payments-2.0.1.tgz
npm notice package size:  30.5 kB
npm notice unpacked size: 131.2 kB
npm notice shasum:        96fc0a9a828e4fb9cc03fd00100323b92895e9d5
npm notice integrity:     sha512-0UGWjJQaKe+Bz[...]4Q/3U9zhax9ow==
npm notice total files:   30

^ Looks like there's an extraneous file or two that could be omitted from the package for next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants