fix: web3 import and ts compiler config

[nikoferro]

This PR fixes:

• Web3 import: makes it work after transpiling
• TSConfig: excludes test from the dist
• TSConfig: target ES2020
• Config files: change to JSON format
• BN.js: included as part of the @metamask/controller-utils updates. Aims to remove BigNumber usage in a future version

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

[legobeat]

Why is changing compile target from es2017 to esnext done here? How is it "better"?

[nikoferro]

@legobeat its to target the latest supported by our TypeScript version. I need to explain better the PR description, but with "better" i was not referring to this change in particular, but the previous configuration was also including test files on the dist, so better in terms of "we are packaging only what we need"

[legobeat]

I guess I feel a bit hesitant about this one, as well as the lib removal on :7, timing-wise... The rest looks straightforward enough, but there's also a lot going on here.

Was thinking perhaps the changes in this PR can be broken into more than one PR, so they can be more easily reviewed and merged independently.

But this may be more straightforward to someone more familiar with that context!

[nikoferro]

in this very particular case, its really straightforward. lib was removed because we dont need definitions for browser environment (since this is only used on mobile), and since our target changed, the ES2020 inclusion in lib, no longer makes sense.

i merged your suggestion to go from ESNext to ES2020 to move slower in terms of target

if its worth mentioning, i have also run integration tests on top of a mobile build using this new set of options and everything works as expected

[legobeat]

LGTM!