feat: allow using a chainId or networkClientId to fetch top assets #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR allows passing in either a
chainId
or anetworkClientId
tofetchTopAssets
. Previously onlynetworkClientId
was allowed.This is to support the case of Bridge where a user could select a destination chain that they have not added to MM yet, there by not having a
networkClientId
to provide. The user will have a destinationchainId
that we want to look up top assets on.References
Related to MetaMask/metamask-mobile#14258
Changelog
@metamask/swaps-controller
chainId
or anetworkClientId
tofetchTopAssets
. Previously onlynetworkClientId
was allowed.Checklist