Skip to content

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Apr 5, 2024

the shareSecret in the encryption use both ephmeral publickey and private key
it should use publickey from the input

Replace with curvelib's encryption

Copy link
Contributor

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ieow ieow changed the title fix: encryption fix: Remove CryptoSwift Apr 8, 2024
Copy link
Contributor

@metalurgical metalurgical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metalurgical metalurgical merged commit cd26539 into master Apr 17, 2024
@metalurgical metalurgical deleted the fix/encryption branch April 17, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants