feat: full refactor to align torus-utils-swift to torus.js #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2024
|
Closes #94 |
metalurgical
force-pushed
the
feature_updates
branch
from
1555c79 to
af687db
Compare
…ll from handleRetrieveShares
Re-align the current implementation of torus-utils-swift to that of the web implementation of torus.js. This will reduce the overhead of differences a developer would need to remember between the two and provide an overall better experience. This will also provide better long term maintainability and make feature parity simpler to implement between the two. The are also numerous bug fixes implemented in this PR as well, one of which allowed the package AnyCodable as a dependency to be removed. Should be feature-complete up until tag v12.3.5 on torus.js
metalurgical
force-pushed
the
feature_updates
branch
from
9a6d003 to
976da30
Compare
himanshuchawla009
suggested changes
Jul 18, 2024
change legacyMetadataHost to metadataHost for getOrSetSapphireMetadataNonce() function. add test for hexEncodedToString()
himanshuchawla009
suggested changes
Jul 19, 2024
metalurgical
force-pushed
the
feature_updates
branch
from
d23b2f3 to
22d913f
Compare
himanshuchawla009
suggested changes
Jul 22, 2024
fix: polyEval calculation fix: missing not in comparison of TorusUtils.isLegacyNetworkRouteMap fix: check on extendedVerifierId fix: throw on invalid pubNonce formatting
himanshuchawla009
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to re-align the current implementation of torus-utils-swift to that of the web implementation of torus.js.
This will reduce the overhead of differences a developer would need to remember between the two and provide an overall better experience.
This will also provide better long term maintainability and make feature parity simpler to implement between the two.
The are also numerous bug fixes implemented in this PR as well, one of which allowed the package AnyCodable as a dependency to be removed.
This PR should be feature-complete up until tag v12.3.5 on torus.js (commit hash: 0160ae8fb4c622ba44c1e80872da2d17cb0e8650). Note: The import share implementation is a simplified implementation taken from the alpha branch of the same repo.
Note this is a breaking change and needs to be released as a major version.
For reviewers, it will be significantly easier to review this side-by-side with web rather than just trying to review the diff. Probably the best way to start would be to compare the test cases first.