Skip to content

chore: replace calls of the slow superstruct "is" with faster regex #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

chore: replace calls of the slow superstruct "is" with faster regex #270

merged 1 commit into from
Sep 24, 2025

Conversation

@bfullam
Copy link
Contributor

@bfullam bfullam commented Sep 24, 2025

The current use of the is function from the superstruct package is drastically slowing down caip type checks. This replaces those function calls with much faster regex checks.

@bfullam bfullam enabled auto-merge (squash) September 24, 2025 11:37
@bfullam bfullam merged commit 890dab0 into main Sep 24, 2025
22 checks passed
@bfullam bfullam deleted the replace-caip-superstruct-with-regex branch September 24, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccharly ccharly ccharly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bfullam @ccharly