Skip to content

update #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2023
Merged

update #17

merged 1 commit into from
Nov 21, 2023

Conversation

@metalurgical
Copy link
Contributor

@metalurgical metalurgical commented Nov 21, 2023 •
edited
Loading

Only include windows specific files if WINDOWS_PLATFORM
Apply singleton pattern to KeyStoreUtils
Include missing pragma once
Decorate KeyStoreUtils->StorageInstance with UPROPERTY for unreal engine to manage it

@metalurgical
update
5628b06 
Only include windows specific if WINDOWS_PLATFORM
Apply singleton pattern to KeyStoreUtils
Include missing pragma once
Decorate StorageInstance with UPROPERTY
chaitanyapotti
chaitanyapotti approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 03a3d08 into main Nov 21, 2023
@chaitanyapotti chaitanyapotti deleted the cleanup branch November 21, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@grvgoel81 grvgoel81 grvgoel81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metalurgical @chaitanyapotti @grvgoel81