Skip to content

fix: android packaging #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2023
Merged

fix: android packaging #22

merged 3 commits into from
Dec 4, 2023

Conversation

@metalurgical
Copy link
Contributor

fix example config.
fix build error.
fix permissions.

grvgoel81
grvgoel81 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@grvgoel81 grvgoel81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

chaitanyapotti
chaitanyapotti approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 7daa0e0 into main Dec 4, 2023
@chaitanyapotti chaitanyapotti deleted the fix_android branch December 4, 2023 09:37
@metalurgical
Copy link
Contributor Author

resolve #20

@grvgoel81 grvgoel81 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@grvgoel81 grvgoel81 grvgoel81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metalurgical @chaitanyapotti @grvgoel81