Skip to content

Conversation

@richardhj
Copy link
Member

Description

Introduce the IItem::getVariantBase() as described in #237.

Unit tests for IItem::getVariants(), IItem::isVariant(), IItem::isVariantBase(), IItem::getVariantBase() unneeded?

Checklist

  • Read and understood the CONTRIBUTING guidelines
  • Created tests, if possible
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself to the @authors in touched PHP files
  • Checked the changes with phpcq and introduced no new issues

@zonky2
Copy link
Contributor

zonky2 commented Feb 12, 2017

current year is 2017 ;-)

@richardhj richardhj force-pushed the feature/iitem-getvariantbase branch from effcc23 to 6ef3a24 Compare February 12, 2017 09:28
@zonky2 zonky2 added the enhancement This issue is about an enhancement (aka new feature) label Feb 12, 2017
@zonky2 zonky2 added this to the 2.0.0 milestone Feb 12, 2017
@discordier
Copy link
Member

Unit tests for IItem::getVariants(), IItem::isVariant(), IItem::isVariantBase(), IItem::getVariantBase() unneeded?

Unit tests are always needed, however they are most times omitted because the dev was too lazy. 😄
I'd be happy if you could add them (and if possible even more) over the time.

@zonky2
Copy link
Contributor

zonky2 commented Mar 15, 2017

hi @richardhj it´s possible to write the unit test? we should merge the PR asap

@richardhj
Copy link
Member Author

I'm not sure what the unit tests should cover.

@zonky2 zonky2 added the Up for discussion This ticket will be up for discussion in one of our next calls label Mar 28, 2017
@discordier discordier merged commit 6ef3a24 into MetaModels:hotfix/alpha-15 Apr 19, 2017
discordier added a commit that referenced this pull request Apr 19, 2017
This implements feature request #237 by adding the requested method:
`IItem::getVariantBase()`.
@richardhj richardhj deleted the feature/iitem-getvariantbase branch April 25, 2017 08:24
@zonky2 zonky2 removed the Up for discussion This ticket will be up for discussion in one of our next calls label May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This issue is about an enhancement (aka new feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants