Skip to content

Min/max date inputs error badly if you input an invalid date #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 25, 2024
Merged

Min/max date inputs error badly if you input an invalid date #1498

merged 6 commits into from
Nov 25, 2024

Conversation

@ncarazon
Copy link
Contributor

@ncarazon ncarazon commented Nov 22, 2024

  • fixed fatal error on min/max input change
  • adjusted default value for numeric group min/max value

Related to #1448

@ncarazon ncarazon force-pushed the fix/minmax-date-inputs-error-badly-if-you-input-an-invalid-date branch from 1fbde0f to 78c3d03 Compare November 22, 2024 17:14
hlbmtc
hlbmtc approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@hlbmtc hlbmtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I assume there could be the same issues with DatetimeUtc component.

Also, It could be a good chance to replace datetime-local inputs with DatetimeUtc if this makes sense

@ncarazon ncarazon force-pushed the fix/minmax-date-inputs-error-badly-if-you-input-an-invalid-date branch from 78c3d03 to 49c0465 Compare November 25, 2024 14:39
@ncarazon ncarazon merged commit 035eced into main Nov 25, 2024
2 checks passed
@ncarazon ncarazon deleted the fix/minmax-date-inputs-error-badly-if-you-input-an-invalid-date branch November 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elisescu elisescu elisescu approved these changes

@hlbmtc hlbmtc hlbmtc approved these changes

@lsabor lsabor Awaiting requested review from lsabor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ncarazon @elisescu @hlbmtc