Conversation
debian/sprout.init.d
Outdated
There was a problem hiding this comment.
There's 4 slightly different ways here of adding a parameter to the DAEMON_ARGs. Can you tidy this up as part of this fix so that they match? Also, I assume there isn't a problem here if $additional_home_domains doesn't exist?
There was a problem hiding this comment.
It's fine if additional_home_domains doesn't exist - it's just blank and fails the test.
Let's discuss on Monday about commonizing the ways of adding a parameter to DAEMON_ARGS. I think the if ... then ... fi vs [ ! ... ] || ... distinction makes sense - the former is better for more complex expressions and the latter for simpler. The ..._arg approach vs directly manipulating DAEMON_ARGS is more interesting.
|
Couple of minor questions, otherwise fine |
[Reviewer: Mike] Support any realm that the HSS gives us
Ellie,
Please can you review my changes for multiple domain support?
Thanks,
Matt