Update React Router Dom To 6.x #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StorytellerCZ
requested changes
Aug 30, 2022
Member
StorytellerCZ
left a comment
StorytellerCZ
left a comment
There was a problem hiding this comment.
I'm not using this package so testing is needed by those who do. Code wise I don't see anything offending, just need to change to major version release.
package.js
Outdated
| Package.describe({ | ||
| name: 'communitypackages:react-router-ssr', | ||
| version: '3.0.4', | ||
| version: '3.0.5', |
Member
There was a problem hiding this comment.
This will have to be a major version release due to the breaking changes in react-router
Update React Router Dom To 6.x and Update a major version release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.