Skip to content

Conversation

@valentind-met
Copy link
Contributor

@valentind-met valentind-met commented Feb 21, 2023

Goal

This PR is adding a flow model in sensors to ease model convergence.

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass.
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@valentind-met valentind-met added the ✨enhancement New feature or request label Feb 21, 2023
@valentind-met valentind-met self-assigned this Feb 21, 2023
@pierre-eliep-met pierre-eliep-met self-requested a review February 21, 2023 10:07
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments and changes, I'll let you decide how you take them into acount :)

nominal=(T_0 +Constants.T0_degC_in_K) *Constants.degC_to_degF +Constants.T0_degC_in_degF); // Temperature in degF
equation
T = Medium.temperature(state);
T = isoPHFlowModel.T_in;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is weird that there is no isoPHFlowModel.T variable, can you add it in isoPHFlowModel and call it here ?

@valentind-met valentind-met merged commit f8d0496 into main Feb 21, 2023
@valentind-met valentind-met deleted the flowmodel_in_sensor branch February 21, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants