Skip to content

Conversation

@alexandreh-met
Copy link
Contributor

@alexandreh-met alexandreh-met commented Mar 25, 2025

Goal

Added an opening connector to the IGV component and modify the gas turbine examples accordingly.
Resolves #522

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass
  • I have checked that my work is compatible with OpenModelica
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@alexandreh-met alexandreh-met linked an issue Mar 25, 2025 that may be closed by this pull request
@alexandreh-met alexandreh-met self-assigned this Mar 25, 2025
@alexandreh-met alexandreh-met added the ✨enhancement New feature or request label Mar 25, 2025
@alexandreh-met alexandreh-met marked this pull request as ready for review March 25, 2025 16:04
@nabily-met
Copy link
Contributor

I would say this is a breaking change. Models that has an IGV component should now connect them to an opening sensor or and equation will be missing.

@alexandreh-met alexandreh-met merged commit c06bdc5 into main Mar 27, 2025
@alexandreh-met alexandreh-met deleted the AH_IGV_connector branch March 27, 2025 10:15
@alexandreh-met
Copy link
Contributor Author

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Opening connector to IGV component

3 participants