Skip to content

tech: cleaning up logs from investigation #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2018
Merged

tech: cleaning up logs from investigation #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdc80c0
tech: cleaning up logs from investigation
hpe-demo-user Jun 26, 2018
1eb75a1
Merge branch 'master' into yuri-cleanup
radislavB Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions ...tions-sdk/src/main/java/com/hp/octane/integrations/services/bridge/BridgeServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
import java.util.Map;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.RejectedExecutionHandler;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.ThreadPoolExecutor;

import static com.hp.octane.integrations.api.RestService.ACCEPT_HEADER;
import static com.hp.octane.integrations.api.RestService.ANALYTICS_CI_PATH_PART;
Expand Down Expand Up @@ -75,27 +73,14 @@ public BridgeServiceImpl(Object internalUsageValidator, RestService restService,
this.tasksProcessor = tasksProcessor;

logger.info("starting background worker...");

((ThreadPoolExecutor) connectivityExecutors).setRejectedExecutionHandler(new RejectedExecutionHandler() {
@Override
public void rejectedExecution(Runnable runnable, ThreadPoolExecutor threadPoolExecutor) {
logger.error("execution REJECTED, retrying after a short while");
doWait(1000);
startBackgroundWorker();
}
});
startBackgroundWorker();
}

// this should be infallible everlasting worker
private void startBackgroundWorker() {
try {
logger.info("pool size: " + ((ThreadPoolExecutor) connectivityExecutors).getPoolSize() + ", active: " + ((ThreadPoolExecutor) connectivityExecutors).getActiveCount());
connectivityExecutors.execute(new Runnable() {
public void run() {

logger.info("executing getAbridgedTasks...");

try {
String tasksJSON;
CIServerInfo serverInfo = pluginServices.getServerInfo();
Expand All @@ -121,15 +106,13 @@ public void run() {
if (tasksJSON != null && !tasksJSON.isEmpty()) {
handleTasks(tasksJSON);
}
logger.info("finished backgroundWorker");
} catch (Throwable t) {
logger.error("connection to Octane Server temporary failed", t);
doWait(1000);
logger.error("getting tasks from Octane Server temporary failed", t);
doWait(2000);
startBackgroundWorker();
}
}
});
logger.info("executing on connectivityExecutors finished");
} catch (Throwable t) {
logger.error("error executing startBackgroundWorker", t);
}
Expand Down Expand Up @@ -192,8 +175,9 @@ private String getAbridgedTasks(String selfIdentity, String selfType, String sel

private void handleTasks(String tasksJSON) {
try {
logger.info("parsing tasks...");
OctaneTaskAbridged[] tasks = dtoFactory.dtoCollectionFromJson(tasksJSON, OctaneTaskAbridged[].class);
logger.info("going to process " + tasks.length + " tasks");
logger.info("parsed " + tasks.length + " tasks, processing...");
for (final OctaneTaskAbridged task : tasks) {
taskProcessingExecutors.execute(new Runnable() {
public void run() {
Expand Down