Skip to content

Commit 16d5d5e

Browse files
mubinsyed2kartben
authored andcommitted
west_commands: runners: Fix parameters passed to xsdb
Existing logic is passing elf file as parameter only when fsbl or bit file parameter is present. This is incorrect, elf file should be always passed irrespective of other parameters. Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
1 parent c684fea commit 16d5d5e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

scripts/west_commands/runners/xsdb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@ def do_run(self, command, **kwargs):
5454
elif self.fsbl:
5555
cmd = ['xsdb', self.xsdb_cfg_file, self.elf_file, self.fsbl]
5656
else:
57-
cmd = ['xsdb', self.xsdb_cfg_file]
57+
cmd = ['xsdb', self.xsdb_cfg_file, self.elf_file]
5858
self.check_call(cmd)

scripts/west_commands/tests/test_xsdb.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@
1313
"config": None,
1414
"bitstream": None,
1515
"fsbl": None,
16-
"expected_cmd": ["xsdb", "default_cfg_path"],
16+
"expected_cmd": ["xsdb", "default_cfg_path", RC_KERNEL_ELF],
1717
},
1818
{
1919
"config": "custom_cfg_path",
2020
"bitstream": None,
2121
"fsbl": None,
22-
"expected_cmd": ["xsdb", "custom_cfg_path"],
22+
"expected_cmd": ["xsdb", "custom_cfg_path", RC_KERNEL_ELF],
2323
},
2424
{
2525
"config": None,

0 commit comments

Comments
 (0)