Imported "rxjs/add/observable/throw" to enable Observable.throw#10
Merged
billba merged 1 commit intomicrosoft:masterfrom Mar 3, 2017
Merged
Imported "rxjs/add/observable/throw" to enable Observable.throw#10billba merged 1 commit intomicrosoft:masterfrom
billba merged 1 commit intomicrosoft:masterfrom
Conversation
So that we don't get "throw" is undefined when an error occurs.
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Member
|
Thanks very much! |
Author
|
Pleasure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an error occurred (eg. token refresh fails because there is no internet connectivity), Observable.throw would get called, but then we get a javascript error because "throw" does not exist on Observable yet.
I had to import "rxjs/add/observable/throw" to get it to work.