Fix ChakraCore retail build#894
Conversation
|
|
||
| inline void SetPattern(UnifiedRegex::RegexPattern* pattern); | ||
| inline void SetSplitPattern(UnifiedRegex::RegexPattern* splitPattern); | ||
| void SetPattern(UnifiedRegex::RegexPattern* pattern) |
There was a problem hiding this comment.
IMO inline is fine on this new definition. Also applies to one below
There was a problem hiding this comment.
Yeah, i think its fine too but it's probably unnecessary. IIRC, inline is implied for member functions defined within a class definition
There was a problem hiding this comment.
IIRC, inline is implied for member functions defined within a class definition
Yes. They are actually defined within a class JavascriptRegExp
There was a problem hiding this comment.
Oh. @chakrabot has merged this one without putting back inline ?
Mostly just fixing link errors by explicitly instantiating templatized functions. Hello world works on Linux retail builds now.
digitalinfinity
force-pushed
the
cc_retail
branch
from
c3c44ce to
1552054
Compare
|
@jianchun please review |
| { | ||
| const wchar_t *fileContent; | ||
| char *fileName; | ||
| char *fileName = (char*) "script.js"; |
There was a problem hiding this comment.
We're hardcoding this value?
There was a problem hiding this comment.
Yup, this was the existing behavior- it looks like if a path is not provided, the default is script.js
|
LGTM |
1 similar comment
|
LGTM |
Merge pull request #894 from digitalinfinity:cc_retail Mostly just fixing link errors by explicitly instantiating templatized functions. Hello world works on Linux retail builds now.
6 participants
Mostly just fixing link errors by explicitly instantiating templatized functions.
Hello world works on Linux retail builds now.