New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloads for string attribute functions #71

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
3 participants
@frederik-h
Contributor

frederik-h commented May 29, 2018

Hi,
several functions of the LLVM C-API for handling attributes
take string arguments. In the C-API,
a string is represented as a pointer
together with the length of the string.
This representation is currently exposed
in the LLVMSharp methods.

This commit adds overloads for the
corresponding methods which hide
the unnecessary length arguments.

Add overloads for string attribute functions
Several functions for handling attributes
take string arguments. In the C-API,
a string is represented as a pointer
together with the length of the string.
This representation is currently exposed
in the LLVMSharp methods.

This commit adds overloads for the
corresponding methods which hide
the unnecessary length arguments.
@msftclas

This comment has been minimized.

msftclas commented May 29, 2018

CLA assistant check
All CLA requirements met.

@mjsabby mjsabby merged commit 7ed37c2 into Microsoft:master Jul 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@mjsabby

This comment has been minimized.

Member

mjsabby commented Jul 2, 2018

Thanks @frederik-h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment