Operation parameter extensions not parsed

[JohnGalt1717]

I have the following in the swagger endpoint:

"/v1/Invoices/GetInventoryItemPrice": {
      "get": {
        "tags": [
          "Invoices"
        ],
        "summary": "Returns the price for the given inventory number between the two parties",
        "operationId": "V1InvoicesGetInventoryItemPriceGet",
        "consumes": [],
        "produces": [
          "application/json",
          "text/json",
          "application/xml",
          "text/xml",
          "application/bson"
        ],
        "parameters": [
          {
            "name": "fromContactId",
            "in": "query",
            "description": "",
            "required": false,
            "type": "integer",
            "format": "int32"
          },
          {
            "name": "toContactId",
            "in": "query",
            "description": "",
            "required": false,
            "type": "integer",
            "format": "int32"
          },
          {
            "name": "toContactType",
            "in": "query",
            "description": "",
            "required": false,
            "type": "string",
            "enum": [
              "User",
              "Organization"
            ],
            "x-ms-enum": {
              "name": "ContactTypes",
              "modelAsString": true,
              "values": [
                {
                  "value": 1,
                  "name": "User",
                  "description": "User"
                },
                {
                  "value": 2,
                  "name": "Organization",
                  "description": "Organization"
                }
              ]
            }
          },
          {
            "name": "inventoryId",
            "in": "query",
            "description": "",
            "required": false,
            "type": "integer",
            "format": "int32"
          },
          {
            "name": "units",
            "in": "query",
            "description": "",
            "required": false,
            "type": "number",
            "format": "double"
          }
        ],
        "responses": {
          "200": {
            "description": "Success",
            "schema": {
              "format": "double",
              "type": "number"
            }
          },
          "401": {
            "description": "Unauthorized"
          },
          "403": {
            "description": "Forbidden"
          }
        },
        "security": [
          {
            "oauth2": [
              "api1"
            ]
          }
        ]
      }
    },

Note toContactType:

{
            "name": "toContactType",
            "in": "query",
            "description": "",
            "required": false,
            "type": "string",
            "enum": [
              "User",
              "Organization"
            ],
            "x-ms-enum": {
              "name": "ContactTypes",
              "modelAsString": true,
              "values": [
                {
                  "value": 1,
                  "name": "User",
                  "description": "User"
                },
                {
                  "value": 2,
                  "name": "Organization",
                  "description": "Organization"
                }
              ]
            }
          },

which clearly has x-ms-enum as an extension. If this was on a schema type, it works fine and the extension is pulled in. However when it's on a parameter of an operation it fails and the extension collection is 0 length.

[darrelmiller]

Hey @JohnGalt1717 , can you confirm which version of the library you are using. The latest code seems to be parsing this properly.

[JohnGalt1717]

Microsoft.OpenApi.Readers V 1.0.1

Under .NET Core Console app if that matters. Param.Extensions.Count = 0

[darrelmiller]

@JohnGalt1717 Thanks for confirming. I hope to have a release of the 1.1 library tomorrow. That should resolve the issue.

[JohnGalt1717]

I tried the beta and it wasn't fixed there.

[darrelmiller]

@JohnGalt1717 Any chance you have setup an ExtensionParser for x-ms-enum?

[JohnGalt1717]

Nope. I just access it directly.

[JohnGalt1717]

bump

[PerthCharern]

@JohnGalt1717 Sorry for the delay, I'll pick this up and take a look this week. I'll get back to you with any updates.

[PerthCharern]

@JohnGalt1717

With the latest code, I got the same result as Darrel above, with the x-ms-enum being deserialized and serialized correctly. I also see the Extension populated in the DOM as well.

1. Any chance you could share with us a bit more about your set-up? I'm not sure what else can affect this apart from the ExtensionParsers that Darrel already mentioned.

2. Also, if you could try running the Microsoft.OpenApi.Workbench project and putting your document there, do you see the x-ms-enum showing up in the result?

[JohnGalt1717]

Sorry I forgot about this. In the latest version it's now showing.