Build fails with `"PreferredUILang" parameter is not supported by the "VsTsc"`

[mhegazy]

After installing TS 2.2 for VS 2015, build fails in VS 2017 with error:

MSB4064	The "PreferredUILang" parameter is not supported by the "VsTsc" task. Verify the parameter exists on the task, and it is a settable public instance property.

More details can be found at https://vsfeedback/comment/826493

[jkonecki]

How was this issue fixed? I experience it with TS 2.2.2 building on VSTS (Hosted)

[mhegazy]

@zhengbli can you look into the vsts issue?

[jkonecki]

I get packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets(204,7): Error MSB4064: The "PreferredUILang" parameter is not supported by the "VsTsc" task. Verify the parameter exists on the task, and it is a settable public instance property. while building the solution.

The targets file is still setting PreferredUILang:

  <Target Name="PreComputeCompileTypeScriptWithTSConfig"
          Condition="'@(ConfigFiles)' != ''">
    <VsTsc
      ToolPath="$(TscToolPath)"
      ToolExe="$(TscToolExe)"
      PreferredUILang="$(PreferredUILang)"
      TSConfigFile="%(ConfigFiles.Identity)"
      YieldDuringToolExecution="$(TscYieldDuringToolExecution)"
      ProjectDir="$(TypeScriptProjectDir)"
      ToolsVersion="$(TypeScriptToolsVersion)"
      TypeScriptCompileBlocked="$(TypeScriptCompileBlocked)"
      ComputeOutputOnly="true">

      <Output TaskParameter="GeneratedJavascript" ItemName="emittedFiles" />
    </VsTsc>
    <ItemGroup>
      <GeneratedJavascript Include="@(emittedFiles)" KeepDuplicates="false" />
    </ItemGroup>
  </Target>

[jkonecki]

I can confirm that removing all instances of PreferredUILang="$(PreferredUILang)" from the Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets solves the problem.
Since there are no code changes related to this issue I can only assume it was closed without actual fix (Issue was closed at the same time as the developer was assigned to investigate it).

Workaround: Remove all instances of PreferredUILang="$(PreferredUILang)" from the packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets file and include the package folder into source control.

[mhegazy]

Can you share the version of the tasks dll?

[jkonecki]

The version of TypeScript.Tasks.dll included in Microsoft.TypeScript.MSBuild.2.2.2.nupkg is 14.40321.1.0

[zhengbli]

@jkonecki can you try set the build output verbosity level to diagnostics by going to tools -> options -> Project and Solutions -> Build and run, and set

And then look for the path of "tsc.exe" in the build output? I would like to see if the correct one was used.

[jkonecki]

I cannot provide the path to tsc.exe as the problem is with calling VsTsc task in the first place.
Here is the detailed output from the build:

2017-03-28T08:20:21.7060412Z ##[debug]Processed: ##vso[task.logdetail id=e5a2f899-a750-4145-b31c-19d9ed8faf18;parentid=;name=packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets;type=Build;starttime=2017-03-28T08:20:21.6940406Z;state=InProgress;]
2017-03-28T08:20:21.7130417Z ##[error]packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets(203,7): Error MSB4064: The "PreferredUILang" parameter is not supported by the "VsTsc" task. Verify the parameter exists on the task, and it is a settable public instance property.
2017-03-28T08:20:21.7130417Z ##[debug]Processed: ##vso[task.logissue type=Error;sourcepath=C:\a\1\s\packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets;linenumber=203;columnnumber=7;code=MSB4064;]The "PreferredUILang" parameter is not supported by the "VsTsc" task. Verify the parameter exists on the task, and it is a settable public instance property.
2017-03-28T08:20:21.7130417Z ##[debug]Processed: ##vso[task.logdetail id=e5a2f899-a750-4145-b31c-19d9ed8faf18;parentid=;type=Build;result=Failed;finishtime=2017-03-28T08:20:21.6990408Z;progress=100;state=Completed;parentid=;name=;]
2017-03-28T08:20:21.7130417Z C:\a\1\s\packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets(203,7): error MSB4064: The "PreferredUILang" parameter is not supported by the "VsTsc" task. Verify the parameter exists on the task, and it is a settable public instance property. [C:\a\1\s\Portfolio\Portfolio.csproj]
2017-03-28T08:20:21.7130417Z ##[error]packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets(199,5): Error MSB4063: The "VsTsc" task could not be initialized with its input parameters. 
2017-03-28T08:20:21.7140418Z ##[debug]Processed: ##vso[task.logissue type=Error;sourcepath=C:\a\1\s\packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets;linenumber=199;columnnumber=5;code=MSB4063;]The "VsTsc" task could not be initialized with its input parameters. 
2017-03-28T08:20:21.7140418Z C:\a\1\s\packages\Microsoft.TypeScript.MSBuild.2.2.2\tools\microsoft.TypeScript.targets(199,5): error MSB4063: The "VsTsc" task could not be initialized with its input parameters.  [C:\a\1\s\Portfolio\Portfolio.csproj]

You need to either remove setting of PreferredUILang input parameter in the targets file (assuming task is correct) or add support for PreferredUILang input parameter to the task (assuming targets file is correct). I suppose the former change should be made.

You might also want to remove the Fixed label from this issue.