Skip to content

Allow exporting a binding before its declaration#14700

Merged
sandersn merged 1 commit intomicrosoft:masterfrom
Jessidhia:allow-export-specifier-reference
Apr 17, 2017
Merged

Allow exporting a binding before its declaration#14700
sandersn merged 1 commit intomicrosoft:masterfrom
Jessidhia:allow-export-specifier-reference

Conversation

@Jessidhia
Copy link
Copy Markdown

@Jessidhia Jessidhia commented Mar 17, 2017

Fixes #14679

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 17, 2017

@Kovensky,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

Jessidhia
Jessidhia commented Mar 17, 2017
View reviewed changes
tests/cases/conformance/es6/modules/exportBinding.ts
export { x }
const x = 'x'

export { Y as Z }
Copy link
Copy Markdown
Author

@Jessidhia Jessidhia Mar 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely, this was not an error; only const and let were errors, even though class Foo {} has the exact same behavior as let Foo = class {} (no hoisting, has TDZ).

@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Mar 17, 2017

LGTM

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 17, 2017

@Kovensky, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@gcnew gcnew mentioned this pull request Apr 3, 2017
Closed
@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Apr 3, 2017

Last call before I merge this

@gcnew gcnew mentioned this pull request Apr 17, 2017
Closed
@sandersn
Copy link
Copy Markdown
Member

sandersn commented Apr 17, 2017

Sorry, looks like we forgot about this one. I'll merge from master and then merge the PR once Travis runs one more time.

@sandersn sandersn merged commit 61ebcb4 into microsoft:master Apr 17, 2017
@sandersn
Copy link
Copy Markdown
Member

sandersn commented Apr 17, 2017

OK, I manually merged after following github's instructions, which don't automatically trigger Travis. So...uh...I'm watching Travis build on master right now. 😅

@Jessidhia Jessidhia deleted the allow-export-specifier-reference branch May 31, 2017 09:12
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jessidhia @msftclas @RyanCavanaugh @sandersn