Use shields.io for badges and add logos#30679
Conversation
ExE-Boss
left a comment
ExE-Boss
left a comment
There was a problem hiding this comment.
The Shields.io Travis badge always reports the latest build, even if that build is from a pull request or an unrelated branch.
The Travis‑CI.org badge only reports the build status of the master branch, which is what you generally want for README.md:
| @@ -1,11 +1,11 @@ | |||
| [](https://travis-ci.org/Microsoft/TypeScript) | |||
| [](https://travis-ci.org/Microsoft/TypeScript) | |||
There was a problem hiding this comment.
| [](https://travis-ci.org/Microsoft/TypeScript) | |
| [](https://travis-ci.org/Microsoft/TypeScript) |
There was a problem hiding this comment.
Turns out that Shields.io now supports Travis branch builds too:
| [](https://travis-ci.org/Microsoft/TypeScript) | |
| [](https://travis-ci.org/Microsoft/TypeScript) |
There was a problem hiding this comment.
Why logoColor=white?
LGTM other than that.
There was a problem hiding this comment.
It looks better than without it:
There was a problem hiding this comment.
Huh, why does it turn blue when you pass it the master branch? Without it the default is
There was a problem hiding this comment.
Because I used the simple-icons travis-ci logo, instead of the shields.io travis logo.
There was a problem hiding this comment.
Oh, it's a difference of travis vs travis-ci. I wasn't aware shields added their own logos since it also uses simpleicons. In that case, travis should have probably been kept anyways since it aligns with the style of the npm logo - which shields has no way of setting to the simpleicons version since they're both named the same (it doesn't look great either).
|
We're pretty OK with the badges as-is, and this is already turning into bikeshedding. |
3 participants
Fixes a README beauty shortfall 🎉